Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accepting suggestions assigns correct translation credit but we need review credit #2406

Closed
dwaynebailey opened this issue Jul 26, 2012 · 3 comments
Assignees
Milestone

Comments

@dwaynebailey
Copy link
Member

If a suggestion is accepted then we give credit to the person who made the suggestion. But we don't track who accepted the suggestion.

Problem:
Without knowing that this came from a suggestion or who accepted it it might present a problem in future to determine where bad strings are coming from.

Solution:
Layer the gravatars. One for the person who suggested the translation and one for the person who accepted. Something like this:


| |

--
-----
@dwaynebailey
Copy link
Member Author

This is more generally an idea of source of the original string.

In this case our source is a suggestion.

But sources could include:

  • suggestions
  • reverts
  • Translation Memory
  • Machine Translation

With the later if you knew that the person started with an MT suggestion then you might know why the string is bad and how to communicate with them on the issue.

@julen
Copy link
Contributor

julen commented Feb 13, 2013

*** Bug #2703 has been marked as a duplicate of this bug. ***

@julen
Copy link
Contributor

julen commented Feb 14, 2013

Reviewer information was stored in a separate Suggestion model (from pootle_app.models.suggestion) so it was actually possible to query that data — in a quite ugly manner though. I have filed bug #2712 for further improvements over the backend schema.

Fixed in fb94294

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants