Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Way too much going on for an example #30

Open
mikbe opened this issue May 11, 2014 · 1 comment
Open

Way too much going on for an example #30

mikbe opened this issue May 11, 2014 · 1 comment

Comments

@mikbe
Copy link

mikbe commented May 11, 2014

Thank you very much for taking your time to share this example.

The issue is it's way too complicated. There's too much going on in this example that has nothing to do with jquery fileupload or paperclip. There's all sorts of stuff that distracts from the example at hand.

Imagine if someone asked you how to bake an apple pie and you started describing how to create a universe.

As you can see by all the issues, it's better to keep an example simple with no extra fluff. An example should contain the bare minimum to get the point across.

Thank you again.

@nozpheratu
Copy link

I began working on my own jquery-fileupload example implementation using Rails 4, Paperclip, and Simple Form after seeing that this one wasn't being maintaned. Here's the link:

https://github.com/nozpheratu/jquery-fileupload-rails-4

There's a tiny bit of create callback coffeescript running in the background to append images to the page after the form gets submitted, but other than that it's about as simple as it gets - perhaps too simple at the moment as there isn't any progress indicators or cancel buttons as seen in the demo application, but a pretty solid scaffolding to work off of. If you feel you can make it better feel free to open a pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants