Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style-guide: add disambiguation page documentation #15749

Merged
merged 2 commits into from
Feb 22, 2025
Merged

style-guide: add disambiguation page documentation #15749

merged 2 commits into from
Feb 22, 2025

Conversation

Managor
Copy link
Collaborator

@Managor Managor commented Feb 18, 2025

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

Closes #8786

@github-actions github-actions bot added the documentation Issues/PRs modifying the documentation. label Feb 18, 2025
@Managor Managor mentioned this pull request Feb 18, 2025
Closed
@Managor Managor changed the title style-guide: add disambiguation pages style-guide: add disambiguation page documentation Feb 18, 2025
sbrl
sbrl approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this into writing, @Managor. Nice one!

kbdharun
kbdharun approved these changes Feb 22, 2025
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding the new section. This PR is GTG.

@kbdharun kbdharun merged commit 10337fb into tldr-pages:main Feb 22, 2025
4 checks passed
@Managor Managor deleted the disambiguation branch February 22, 2025 16:06
@MachiavelliII MachiavelliII mentioned this pull request Feb 22, 2025
Open
This was referenced Feb 23, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrl sbrl sbrl approved these changes

@gutjuri gutjuri gutjuri approved these changes

@kbdharun kbdharun kbdharun approved these changes

Assignees
No one assigned
Labels
documentation Issues/PRs modifying the documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dealing with name collisions (in the same platform)
4 participants
@Managor @sbrl @gutjuri @kbdharun