Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm-logout: add page #14835

Merged
merged 9 commits into from
Nov 16, 2024
Merged

npm-logout: add page #14835

merged 9 commits into from
Nov 16, 2024

Conversation

martinblume
Copy link
Contributor

@martinblume martinblume commented Nov 14, 2024 •
edited
Loading

  • The page(s) are in the correct platform directories: common
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):10.9.0

@github-actions github-actions bot added new command Issues requesting creation of a new page or PRs adding a new page for a command. page edit Changes to an existing page(s). labels Nov 14, 2024
spageektti
spageektti reviewed Nov 15, 2024
View reviewed changes
Copy link
Member

@spageektti spageektti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Thank you so much for your contribution!

@martinblume @spageektti
Fix styling of description
f8cefed 
Co-authored-by: Wiktor Perskawiec <[email protected]>
sebastiaanspeck
sebastiaanspeck reviewed Nov 16, 2024
View reviewed changes
Copy link
Member

@sebastiaanspeck sebastiaanspeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To match more with npm-login

martinblume and others added 4 commits November 16, 2024 10:11
@martinblume @sebastiaanspeck
Improve wording
58c4a27 
Co-authored-by: Sebastiaan Speck <[email protected]>
@martinblume @sebastiaanspeck
Improve wording
08997d9 
Co-authored-by: Sebastiaan Speck <[email protected]>
@martinblume @sebastiaanspeck
Improve wording
89fa680 
Co-authored-by: Sebastiaan Speck <[email protected]>
@martinblume
Merge branch 'main' into feature/npm-logout-page
0a9c064
gutjuri
gutjuri approved these changes Nov 16, 2024
View reviewed changes
@sebastiaanspeck sebastiaanspeck merged commit dc01fda into tldr-pages:main Nov 16, 2024
4 checks passed
@Managor Managor mentioned this pull request Dec 27, 2024
Open
67 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastiaanspeck sebastiaanspeck sebastiaanspeck left review comments

@gutjuri gutjuri gutjuri approved these changes

@spageektti spageektti spageektti approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command. page edit Changes to an existing page(s).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@martinblume @sebastiaanspeck @gutjuri @spageektti