make install breaks when repo is checked out with git

[hrehfeld]

$ make check-deps
jj-fzf 0.24.0
Error: There is no jj repo in "."
Hint: It looks like this is a git repo. You can create a jj repo backed by it by running this:
jj git init --colocate
jj-fzf: **ERROR**: /home/hrehfeld/projects/arch-packages/jj-fzf/src/jj-fzf: not a JJ repository
make: *** [Makefile:14: check-deps] Error 127

check-deps seems to be required by install

This sucks, because e.g. an archlinux PKGBUILD relies on using git.

[hrehfeld]

https://aur.archlinux.org/packages/jj-fzf

[tim-janik]

https://aur.archlinux.org/packages/jj-fzf

Please correct me if I am wrong, but doesn't this lack a dependency on jj?
https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=jj-fzf

I guess we could get make install to work on a pur .git repo, but having the jj executable around is a hard dependency.

[hrehfeld]

Thanks! Fixed the dependencies.

And sorry, it was a little late yesterday:

• jj was in path while testing make check-deps.

• the culprit is ofc that jj-fzf --help fails if .jj hasn't been initialized. jj --help works fine tho, so I think jj-fzf should mirror that behavior?

I can work around that by initializing jj during PKGBUILD 🤷

However, if I do that and then just make install with the $pkgdir:

install -c -t "/home/hrehfeld/projects/arch-packages/jj-fzf/pkg/jj-fzf/bin" jj-fzf
install: failed to access '/home/hrehfeld/projects/arch-packages/jj-fzf/pkg/jj-fzf/usr/bin': No such file or directory

I guess if you provide a make install, then it should also make sure the target dir exists (and permissions etc):

How about this?

install: check-deps
	mkdir -p "$(bindir)"
	$(INSTALL) -t "$(bindir)" jj-fzf

Sorry for the hassle and thanks for the help/support ;-)

[tim-janik]

Thanks! Fixed the dependencies.

And sorry, it was a little late yesterday:

* `jj` was in path  while testing make check-deps.

* the culprit is ofc that `jj-fzf --help` fails if `.jj` hasn't been initialized. `jj --help` works fine tho, so I think jj-fzf should mirror that behavior?

Yes, but it's a bit involved which is why I haven't gotten around to it yet.

How about this?

install: check-deps
	mkdir -p "$(bindir)"
	$(INSTALL) -t "$(bindir)" jj-fzf

Using install should take care of that, can you try recent trunk or v0.25.0 that had some Makefile fixes?