Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The flow-round-by-digit value will be changed after restart #8980

Closed
nolouch opened this issue Jan 8, 2025 · 3 comments · Fixed by #8981
Closed

The flow-round-by-digit value will be changed after restart #8980

nolouch opened this issue Jan 8, 2025 · 3 comments · Fixed by #8981
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. severity/major type/bug The issue is confirmed as a bug.

Comments

@nolouch
Copy link
Contributor

nolouch commented Jan 8, 2025 •
edited
Loading

Bug Report

What did you do?

run twice

tiup playground nightly --tiflash=0 --tag=tc1

What did you expect to see?

the config should be

 "flow-round-by-digit": 3，

What did you see instead?

first time:

"flow-round-by-digit": 3

second time:

"flow-round-by-digit": 127

What version of PD are you using (pd-server -V)?

7.5.x. -> master
@nolouch nolouch added the type/bug The issue is confirmed as a bug. label Jan 8, 2025
@nolouch
Copy link
Contributor Author

nolouch commented Jan 8, 2025

after #7993

@nolouch nolouch mentioned this issue Jan 8, 2025
Merged
@nolouch nolouch added affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. and removed may-affects-5.4 may-affects-6.1 may-affects-6.5 may-affects-7.1 may-affects-7.5 may-affects-8.1 may-affects-8.4 may-affects-8.5 labels Jan 8, 2025
@rleungx
Copy link
Member

rleungx commented Jan 8, 2025

Seem v7.1.x and v6.5.x also have this issue?

@nolouch
Copy link
Contributor Author

nolouch commented Jan 8, 2025

Yes :(

@nolouch nolouch added affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. labels Jan 8, 2025
@ti-chi-bot ti-chi-bot bot closed this as completed in #8981 Jan 9, 2025
ti-chi-bot bot pushed a commit that referenced this issue Jan 9, 2025
@nolouch
config: completely remove the deprecated field from the PD server con…
31a0ad6 
…fig (#8981)

close #8980

server/config: completely remove the deprecated field from the PD server config

Signed-off-by: nolouch <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this issue Jan 9, 2025
Merged
ti-chi-bot bot pushed a commit that referenced this issue Jan 9, 2025
@ti-chi-bot @nolouch
config: completely remove the deprecated field from the PD server con…
5036cc2 
…fig (#8981) (#8985)

close #8980

server/config: completely remove the deprecated field from the PD server config

Signed-off-by: nolouch <[email protected]>

Co-authored-by: nolouch <[email protected]>
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Jan 26, 2025
@nolouch @ti-chi-bot
This is an automated cherry-pick of tikv#8981
aa13b36 
close tikv#8980

Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this issue Jan 26, 2025
Merged
ti-chi-bot bot pushed a commit that referenced this issue Feb 8, 2025
@ti-chi-bot @nolouch @okJiang
config: completely remove the deprecated field from the PD server con…
bf361c8 
…fig (#8981) (#9026)

close #8980

server/config: completely remove the deprecated field from the PD server config

Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: nolouch <[email protected]>

Co-authored-by: ShuNing <[email protected]>
Co-authored-by: nolouch <[email protected]>
Co-authored-by: okJiang <[email protected]>
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue Feb 11, 2025
@nolouch @ti-chi-bot
This is an automated cherry-pick of tikv#8981
930b4f6 
close tikv#8980

Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this issue Feb 11, 2025
Merged
ti-chi-bot bot added a commit that referenced this issue Feb 12, 2025
@ti-chi-bot @nolouch @ti-chi-bot
config: completely remove the deprecated field from the PD server con…
370c4ce 
…fig (#8981) (#9059)

close #8980

server/config: completely remove the deprecated field from the PD server config

Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: nolouch <[email protected]>

Co-authored-by: ShuNing <[email protected]>
Co-authored-by: nolouch <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

config: completely remove the deprecated field from the PD server config nolouch/pd
2 participants
@nolouch @rleungx