Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write_csv (and any other in the write_delim family) can't export NaN anymore #1146

Closed
jonasfoe opened this issue Nov 9, 2020 · 1 comment

Comments

@jonasfoe
Copy link

jonasfoe commented Nov 9, 2020

Hi,
I have an issue with the commit ccc4dea for readr 1.4.0:

I can't export NaN anymore, which I was using for my work.
Since this was is in line with write.csv() and data.table::fwrite(), I can't export NaN in any user friendly function right now.

So this breaking change is very unfortunate for me.
Would you be interested in a pull request that adds a function argument nan=, which defaults to the na= argument?
This would add back the functionality while keeping the latest change intact.

@jimhester
Copy link
Collaborator

Thanks for filing this issue! Unfortunately, we need to restrict the arguments to only be those used by a significant fraction of users.

Developing good software requires relentless focus, which means that we have to say no to many good ideas.

I would suggest you format your data in the way you desire prior to calling any of the write functions.

e.g. convert all the numeric columns to character data, handling NaN in whatever method you need, then call the writing function.

Even though we're closing this issue, we really appreciate the feedback, and hope you'll continue to contribute in the future 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants