Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Border around white color or make dialog bg customizable #6

Closed
tomredman opened this issue Apr 7, 2016 · 6 comments
Closed

Border around white color or make dialog bg customizable #6

tomredman opened this issue Apr 7, 2016 · 6 comments

Comments

@tomredman
Copy link

Awesome library!

Would be cool to have the white color circle outlined :)

@nwalters512
Copy link
Contributor

Thanks!

It probably makes sense to have all very light colors outlined, not just strictly white. I could repurpose this chunk of code to filter for very light colors and automatically apply a border in that case.

@svsorokina
Copy link

yes, I need this too :)

@RocketRider
Copy link
Contributor

But then you should also add a white outlining around dark colors, think about a night mode.
Not sure how this would look...

@nwalters512
Copy link
Contributor

A dark theme would be an interesting option. That's something for another issue though.

@RocketRider
Copy link
Contributor

It does work as it is, I use it in an app with dark/night mode. But if you will add only black outlinings it would not be perfect...
I'm currently working on your library, I just added the outlining feature. Take a look into my fork.
https://github.com/RocketRider/spectrum/

I will add one more thing, then I will make a pull request, in the hope you will add my changes.

@nwalters512
Copy link
Contributor

Resolved in #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants