Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pointer): trigger contextmenu on mousedown #811

Merged
merged 3 commits into from
Dec 13, 2021
Merged

fix(pointer): trigger contextmenu on mousedown #811

merged 3 commits into from
Dec 13, 2021

Conversation

ph-fritsche
Copy link
Member

What:

Remove TODO for #803 as the behavior is inconsistent across browsers.

Trigger contextmenu on mousedown instead of mouseup.

Apply button and buttons property on all mouse events.

Checklist:

  • Tests
  • Ready to be merged

@ph-fritsche ph-fritsche added this to the userEvent v14 milestone Dec 12, 2021
@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 12, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e939828:

Sandbox Source
userEvent-PR-template Configuration

@codecov
Copy link

codecov bot commented Dec 12, 2021

Codecov Report

Merging #811 (e939828) into beta (1bc5945) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              beta      #811   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           77        77           
  Lines         1575      1574    -1     
  Branches       560       559    -1     
=========================================
- Hits          1575      1574    -1     
Impacted Files Coverage Δ
src/pointer/pointerPress.ts 100.00% <100.00%> (ø)
src/utils/pointer/firePointerEvents.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bc5945...e939828. Read the comment docs.

@ph-fritsche ph-fritsche merged commit e1c4cad into beta Dec 13, 2021
@ph-fritsche ph-fritsche deleted the fix-803 branch December 13, 2021 11:21
@github-actions
Copy link

🎉 This PR is included in version 14.0.0-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant