Skip to content

Commit 0135cd1

Browse files
authored
Merge pull request #2417 from alixander/fix-md-label
fix md label with dark theme and c4 person shape when small
2 parents 9c74fb7 + 4a2b7a2 commit 0135cd1

File tree

15 files changed

+4439
-2
lines changed

15 files changed

+4439
-2
lines changed

d2renderers/d2svg/d2svg.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -1746,9 +1746,10 @@ func drawShape(writer, appendixWriter io.Writer, diagramHash string, targetShape
17461746
}
17471747
if !color.IsThemeColor(targetShape.Color) {
17481748
styles = append(styles, fmt.Sprintf(`color:%s`, targetShape.Color))
1749-
} else {
1749+
} else if inlineTheme != nil {
17501750
styles = append(styles, fmt.Sprintf(`color:%s`, d2themes.ResolveThemeColor(*inlineTheme, targetShape.Color)))
17511751
}
1752+
// When using dark theme, inlineTheme is nil and we rely on CSS variables
17521753

17531754
mdEl.Style = strings.Join(styles, ";")
17541755

e2etests/testdata/txtar/dark-theme-md/dagre/board.exp.json

+99
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

e2etests/testdata/txtar/dark-theme-md/dagre/sketch.exp.svg

+908
Loading

e2etests/testdata/txtar/dark-theme-md/elk/board.exp.json

+99
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

e2etests/testdata/txtar/dark-theme-md/elk/sketch.exp.svg

+908
Loading

e2etests/testdata/txtar/dark-theme-shape/dagre/board.exp.json

+99
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)