fix: SQS queue encryption types selection #2575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`sqs_managed_sse_enabled` and `kms_master_key_id` cannot coexist. prior to this fix, if `queue_managed_sse_enabled` was set to `false`, then `sqs_managed_sse_enabled` would be set to false as well, instead `null`, as it should be in this case.
tal-lederman-dy
changed the title
tal-lederman-dy
changed the title
tal-lederman-dy
changed the title
antonbabenko
pushed a commit
that referenced
this pull request
Apr 18, 2023
### [19.13.1](v19.13.0...v19.13.1) (2023-04-18) ### Bug Fixes * SQS queue encryption types selection ([#2575](#2575)) ([969c7a7](969c7a7))
|
This PR is included in version 19.13.1 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
sqs_managed_sse_enabledandkms_master_key_idcannot coexist. prior to this fix, ifqueue_managed_sse_enabledwas set tofalse, thensqs_managed_sse_enabledwould be set to false as well, insteadnull, as it should be in this case.Motivation and Context
I have tried to change an SQS queue's encryption from "SSE-SQS" to "SSE-KMS", using the karpenter submodule and failed with an error saying "sqs_managed_sse_enabled": conflicts with "kms_master_key_id".
This fixes the issue.
Breaking Changes
None known.
How Has This Been Tested?
I have successfully deployed with this change in my environment, where SQS queues are managed by the karpenter submodule for about 2 months now.
I have executed
pre-commit run -aon my pull request