[tfjs-core] do not hang on invalid browser files #8517
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tf.io.browserFiles
doesn't fail when loading invalid files. or rather, it fails, but never rejects the promise, making theIOHandler.load
hang forever.wrapping the
JSON.parse
call in a try/catch and rejecting accordingly did the trick. and a small test to try it out.note:
FileReader.readAsText()
is a callback way to go around reading files. the promise-basedBlob.text()
would makeBrowserFile.load
simpler and safer (but felt ouf-of-scope here).