Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Javascript Examples #502

Open
fboucquez opened this issue Sep 14, 2020 · 0 comments
Open

Improve Javascript Examples #502

fboucquez opened this issue Sep 14, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@fboucquez
Copy link
Contributor

fboucquez commented Sep 14, 2020

At the moment, javascript examples are compiled versions of the typescript. This is great because we only need to maintain the typescript examples.

The problem is that the "compiled" javascript is too low level. Is it possible to tune the typescript compiler so the code keeps some of newer javascript syntax?

This will get worse if we start using syntax like async-await for the issue #324

https://docs.symbolplatform.com/guides/account/getting-the-amount-of-assets-sent-to-an-account.html

I think just updating the target version of typescript to ES2017 would do the trick

https://github.com/nemtech/symbol-docs/blob/main/source/resources/examples/typescript/tsconfig.json#L4

Also, the typescript compilation is not in package.json, it should be added as a command.

@fboucquez fboucquez added the enhancement New feature or request label Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant