[tools/shoestring] fix: move MongoDB image to config

problem: MongoDB image name is dependent on shoestring version
solution: move MongoDB image to shoestring ini config

Author: Wayonb

tools/shoestring/shoestring/commands/setup.py

@@ -119,6 +119,7 @@ async def run_main(args):
 		preparer.configure_docker({
 			'catapult_client_image': config.images.client,
 			'catapult_rest_image': config.images.rest,
+			'mongo_image': config.images.mongo,
 			'user': f'{config.node.user_id}:{config.node.group_id}',
 			'api_https': config.node.api_https,
 			'light_api': NodeFeatures.API in config.node.features and not config.node.full_api,

tools/shoestring/shoestring/internal/ShoestringConfiguration.py

@@ -7,7 +7,7 @@
 
 from .NodeFeatures import NodeFeatures
 
-ImagesConfiguration = namedtuple('ImagesConfiguration', ['client', 'rest'])
+ImagesConfiguration = namedtuple('ImagesConfiguration', ['client', 'rest', 'mongo'])
 ServicesConfiguration = namedtuple('ServicesConfiguration', ['nodewatch'])
 TransactionConfiguration = namedtuple('TransactionConfiguration', [
 	'fee_multiplier', 'timeout_hours', 'min_cosignatures_count', 'hash_lock_duration', 'currency_mosaic_id', 'locked_funds_per_aggregate'
@@ -32,7 +32,7 @@ def parse_network_configuration(config):
 def parse_images_configuration(config):
 	"""Parses images configuration."""
 
-	return ImagesConfiguration(config['client'], config['rest'])
+	return ImagesConfiguration(config['client'], config['rest'], config['mongo'])
 
 
 def parse_services_configuration(config):

tools/shoestring/shoestring/templates/docker-compose-dual.yaml

@@ -2,7 +2,7 @@
 version: '2'
 services:
   db:
-    image: mongo:7.0.16
+    image: '{{ mongo_image }}'
     user: '{{ user }}'
     command: mongod --dbpath=/dbdata
     stop_signal: SIGINT
@@ -13,7 +13,7 @@ services:
       - ./dbdata:/data:rw
 
   initiate:
-    image: mongo:7.0.16
+    image: '{{ mongo_image }}'
     user: '{{ user }}'
     command: /bin/bash /startup/mongors.sh /real_data/startup/mongo-initialized
     volumes:

tools/shoestring/tests/internal/test_Preparer.py

@@ -726,8 +726,8 @@ def _assert_can_configure_docker(self, config, expected_startup_files, expected_
 		def _assert_can_configure_service(docker_compose_filepath, expected_names):
 			# - check compose file
 			expected_image_map = {
-				'db': 'mongo:7.0.16',
-				'initiate': 'mongo:7.0.16',
+				'db': 'mongo:a.b.c',
+				'initiate': 'mongo:a.b.c',
 				'client': 'symbolplatform/symbol-server:gcc-a.b.c.d',
 				'broker': 'symbolplatform/symbol-server:gcc-a.b.c.d',
 				'rest-api': 'symbolplatform/symbol-rest:a.b.c',
@@ -755,6 +755,7 @@ def _assert_can_configure_service(docker_compose_filepath, expected_names):
 				preparer.configure_docker({
 					'catapult_client_image': 'symbolplatform/symbol-server:gcc-a.b.c.d',
 					'catapult_rest_image': 'symbolplatform/symbol-rest:a.b.c',
+					'mongo_image': 'mongo:a.b.c',
 					'user': '2222:3333',
 					'api_https': config.node.api_https,
 					'light_api': NodeFeatures.API in config.node.features and not config.node.full_api,

tools/shoestring/tests/internal/test_ShoestringConfiguration.py

@@ -31,7 +31,8 @@ class ShoestringConfigurationTest(unittest.TestCase):
 
 	VALID_IMAGES_CONFIGURATION = {
 		'client': 'symbolplatform/symbol-server:gcc-0.0.0.0',
-		'rest': 'symbolplatform/symbol-rest:1.1.1'
+		'rest': 'symbolplatform/symbol-rest:1.1.1',
+		'mongo': 'mongo:2.2.2'
 	}
 
 	VALID_SERVICES_CONFIGURATION = {
@@ -115,6 +116,7 @@ def test_can_parse_valid_images_configuration(self):
 		# Assert:
 		self.assertEqual('symbolplatform/symbol-server:gcc-0.0.0.0', images_config.client)
 		self.assertEqual('symbolplatform/symbol-rest:1.1.1', images_config.rest)
+		self.assertEqual('mongo:2.2.2', images_config.mongo)
 
 	def test_cannot_parse_images_configuration_incomplete(self):
 		# Arrange:

tools/shoestring/tests/resources/sai.shoestring.ini

@@ -9,6 +9,7 @@ generationHashSeed = 49D6E1CE276A85B70EAFE52349AACCA389302E7A9754BCF1221E79494FC
 
 client = symbolplatform/symbol-server:gcc-1.0.3.7
 rest = symbolplatform/symbol-rest:2.4.4
+mongo = mongo:7.0.16
 
 [services]