Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader seems frozen due to completion block on .cancel being ignored #291

Closed
jp7 opened this issue Feb 28, 2024 · 2 comments · Fixed by #298 or woocommerce/woocommerce-ios#14198
Closed

Comments

@jp7
Copy link

jp7 commented Feb 28, 2024

Summary

Completion block on .cancel on SCPCancelable seems to be ignored.

Code to reproduce

Using the Stripe Terminal Example App

See Video: https://drive.google.com/file/d/1v0q7v2U_N1OBljzDipmWOeQCEuh4byZf/view?usp=drive_link

We were able to reproduce this issue by leaving the card in the reader, then trying to create a payment intent and cancel. This seems to happen after a few tries.

There could be other ways to reproduce this issue since a similar problem was found in production and it's unlikely the customer left their card in the reader.

When this happens it looks like the reader ignores all other commands and/or is waiting for the cancel to be completed which doesn't happen. I believe the only way to get out of this state is to toss the app out of memory OR by powering off the reader

iOS version

iPad iOS 16.6.1

Installation method

Ran the example app

SDK version

Version on example app - 3.2.1 , but we have seen a similar issue in our Prod app which is using an older version (SDK beta 9)

Other information

Logs from example App:

Screenshot 2024-02-28 at 9 24 16 AM

Might be similar to this ticket: #103

@bric-stripe
Copy link
Collaborator

Thanks for the clear repro steps and video using the example app and all 🙏 Just ack'ing that we've been able to repro with those steps and are investigating it now. I suspect there's a conflict with the cancel handling and the "card left in reader" logic causing trouble here. Will update when we know more.

@bric-stripe
Copy link
Collaborator

The fix for this issue will ship in our next release, 3.5.0, currently scheduled for April 8th. Thanks again for the detailed report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants