Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file not save correctly #1757

Closed
suisuyy opened this issue Dec 7, 2021 · 11 comments
Closed

file not save correctly #1757

suisuyy opened this issue Dec 7, 2021 · 11 comments

Comments

@suisuyy
Copy link

suisuyy commented Dec 7, 2021

Describe the bug

when i use ctrl+s to save file, it seems not save , the index.js not restart, nodmon not monitor the save, event i use cat index.js, it still show the old file, but when i reload the page, the file is update. this is huge problem

Link to the blitz that caused the error

https://stackblitz.com/edit/runnode?file=index.js

Steps to reproduce

1.change some text in index.js,
2.not rerun
3.use cat index.js,still old content
4.reload page
5.seems changed

Expected behavior

it should save correctly

Screenshots

No response

Platform

Browser name  = Chrome 
Full version  = 95.0.4638.69
Major version = 95
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/95.0.4638.69 Safari/537.36 Edg/95.0.1020.53
performance.memory = {
  "totalJSHeapSize": 68434616,
  "usedJSHeapSize": 65631260,
  "jsHeapSizeLimit": 4294705152
}
Hash = 6c82f838340a5d37c50f004ca724bcc8f75bc71c

Additional context

No response

@HeyGarrison
Copy link
Contributor

Hey 👋 @suisuyy - I'm having trouble reproducing this. We've shipped a lot of updates to the editor recently though so I'm wondering if we fixed this. Could you see if maybe that's the case? ❤️

@suisuyy
Copy link
Author

suisuyy commented Feb 24, 2022

@HeyGarrison
thanks reply.
i found this bug only exist after the project is connected to a github repo.
it works normally without connecting git repo

@suisuyy
Copy link
Author

suisuyy commented Feb 24, 2022

i have recode a short video , you can see i have remove all code and saved in script.js and then reload page ,but the code that has been deleted comeback in the video:
https://mega.nz/file/IuR23DhI#-nT_pUXvBjGYzklVe5xepsbJsnZjRQ8ZSig7hXagZzM

@github-actions
Copy link

A minimal context is required to triage your issue.

Please open a new issue using one of our templates available here

@HeyGarrison HeyGarrison transferred this issue from stackblitz/webcontainer-core Feb 24, 2022
@HeyGarrison HeyGarrison reopened this Feb 24, 2022
@HeyGarrison
Copy link
Contributor

This deals with our git functionality which is currently being re-worked with some of our other roadmap efforts. ❤️

So moving to the core repo since it's not a webcontainer issue.

@fvsch fvsch removed the git label Feb 28, 2022
@kc0tlh
Copy link
Collaborator

kc0tlh commented Aug 23, 2023

This issue is now resolved! Full writeup in Github issue #2473

@kc0tlh kc0tlh closed this as completed Aug 23, 2023
@suisuyy
Copy link
Author

suisuyy commented Sep 6, 2023

yeah,currently stackbliz ide will pull from repo then overwrite local file on every start. the new codeflow ide look very powerful,i need try it, thanks this is great

@suisuyy
Copy link
Author

suisuyy commented Sep 6, 2023

oh,the new codeflow still same as old stackbliz, you cant save your work if you forgot commit to github, files will reset to last commit when open the ide,that not a good behavior

@kc0tlh
Copy link
Collaborator

kc0tlh commented Sep 6, 2023

@suisuyy I thought this had already shipped in VS Code as I know it's planned for the GA launch. Checking with the eng team. Will update you here when I hear back!

@samdenty
Copy link

samdenty commented Sep 7, 2023

@suisuyy we had basic persistence but that was recently removed as it was buggy - we're working on new improved persistence for launch

@suisuyy
Copy link
Author

suisuyy commented Sep 9, 2023

thanks,its amazing work to make vscode in browser, currently
i can set up a auto commit when save , it works ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants