Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source{d} color scheme by default on Charts Visual Properties #255

Closed
ricardobaeta opened this issue Aug 14, 2019 · 3 comments
Closed

source{d} color scheme by default on Charts Visual Properties #255

ricardobaeta opened this issue Aug 14, 2019 · 3 comments
Assignees

Comments

@ricardobaeta
Copy link
Contributor

Context

This issue is related to the source{d}-branded superset UI EPIC, on what concerns the source{d} color scheme by default on chart visual properties Story.

It inherits the same rationale: As a Product, Marketing or sales team member I want product users to have a branded interface so that I can reinforce the source{d} brand in their minds and provide them a coherent end-to-end experience.

This issue didn't birth here, but rather with a very fancy PR made by @dpordomingo, that couldn't have streamlined more the accomplishment of this objective.

Requirements

  • Apply our brand guidelines, mainly regarding colour usage and get the most out of Tints & Shades.
  • Discuss/Propose/Justify/Agree on the design decisions made in the source{d} Branded UI design doc.
  • Test David's PR more times (as color change)
  • Test David's PR for color blindness/impairments
  • Test David's PR color pairs/triples (colors "close" to each other in the palette)
  • Team up with Anita Lillie (Superset Design Community) as she is, in fact, a Data Visualization Designer above all, and she is excited to jump on board.
  • Deliver as a PR

Current status

image

Related

@ricardobaeta ricardobaeta self-assigned this Aug 14, 2019
@dpordomingo
Copy link
Contributor

dpordomingo commented Sep 11, 2019

Is this issue going to be closed by the following issues?

Or is it going to be needed any other work @ricardobaeta ?

@ricardobaeta
Copy link
Contributor Author

ricardobaeta commented Sep 11, 2019

@dpordomingo Yes, it's going to be closed by #258 and #259

@ricardobaeta
Copy link
Contributor Author

@dpordomingo both #258 and #259 are merged. Closing this per objective accomplishment. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants