Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "internal" access modifiers from code #339

Open
richardtop opened this issue Mar 12, 2025 · 1 comment
Open

Remove "internal" access modifiers from code #339

richardtop opened this issue Mar 12, 2025 · 1 comment

Comments

@richardtop
Copy link

richardtop commented Mar 12, 2025

Since "internal" access modifier is the default one, it can be safely removed. Or are there any reasons to actually explicitly state that access modifier for methods/classes?
e.g.: https://github.com/square/Valet/blob/main/Sources/Valet/Internal/Keychain.swift#L20

if this is OK, I can make a PR, or feel free to close the issue if you'd like to keep it this way.

@dfed
Copy link
Collaborator

dfed commented Mar 12, 2025

Indeed the modifier is not necessary. Explicit access control was a style I played with back when we rewrote Valet in Swift. Happy to remove it. Feel free to submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants