You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Indeed the modifier is not necessary. Explicit access control was a style I played with back when we rewrote Valet in Swift. Happy to remove it. Feel free to submit a PR.
Since "internal" access modifier is the default one, it can be safely removed. Or are there any reasons to actually explicitly state that access modifier for methods/classes?
e.g.: https://github.com/square/Valet/blob/main/Sources/Valet/Internal/Keychain.swift#L20
if this is OK, I can make a PR, or feel free to close the issue if you'd like to keep it this way.
The text was updated successfully, but these errors were encountered: