Skip to content

Commit f6dca0b

Browse files
authored
upgrade packages (#2595)
* upgrade packages not supports-color as that requires esm * Remove the ESM bundle in browser check from postbuild This has failed for several years without anyone noticing. Even if the exit status is non-zero, the build does not fail, for whatever reason. So this has no meaning as of now. * Downgrade Browserify * Fix linting issues after upgrade
1 parent 5025d00 commit f6dca0b

9 files changed

+1731
-8771
lines changed

lib/sinon/util/core/get-property-descriptor.js

+12-3
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,18 @@
11
"use strict";
22

3-
/* eslint-disable jsdoc/valid-types */
3+
/**
4+
* @typedef {object} PropertyDescriptor
5+
* @see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/defineProperty#description
6+
* @property {boolean} configurable defaults to false
7+
* @property {boolean} enumerable defaults to false
8+
* @property {boolean} writable defaults to false
9+
* @property {*} value defaults to undefined
10+
* @property {Function} get defaults to undefined
11+
* @property {Function} set defaults to undefined
12+
*/
13+
414
/*
5-
* The following type def is strictly an illegal JSDoc, but the expression forms a
15+
* The following type def is strictly speaking illegal in JSDoc, but the expression forms a
616
* legal Typescript union type and is understood by Visual Studio and the IntelliJ
717
* family of editors. The "TS" flavor of JSDoc is becoming the de-facto standard these
818
* days for that reason (and the fact that JSDoc is essentially unmaintained)
@@ -13,7 +23,6 @@
1323
* a slightly enriched property descriptor
1424
* @property {boolean} isOwn true if the descriptor is owned by this object, false if it comes from the prototype
1525
*/
16-
/* eslint-enable jsdoc/valid-types */
1726

1827
/**
1928
* Returns a slightly modified property descriptor that one can tell is from the object or the prototype

package-lock.json

+1,697-8,752
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+15-15
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
"unimported": "unimported .",
5252
"pretest-webworker": "npm run build",
5353
"prebuild": "rimraf pkg && npm run check-dependencies",
54-
"postbuild": "npm run test-esm-support && npm run check-esm-bundle-runs-in-browser",
54+
"postbuild": "npm run test-esm-support ",
5555
"prebuild-docs": "./scripts/update-compatibility.js",
5656
"prepublishOnly": "npm run build",
5757
"prettier:check": "prettier --check '**/*.{js,css,md}'",
@@ -74,34 +74,34 @@
7474
"*.mjs": "eslint --quiet --ext mjs --parser-options=sourceType:module"
7575
},
7676
"dependencies": {
77-
"@sinonjs/commons": "^3.0.0",
77+
"@sinonjs/commons": "^3.0.1",
7878
"@sinonjs/fake-timers": "^11.2.2",
7979
"@sinonjs/samsam": "^8.0.0",
80-
"diff": "^5.1.0",
81-
"nise": "^5.1.5",
82-
"supports-color": "^7.2.0"
80+
"diff": "^5.2.0",
81+
"nise": "^5.1.9",
82+
"supports-color": "^7"
8383
},
8484
"devDependencies": {
85-
"@babel/core": "^7.23.2",
86-
"@sinonjs/eslint-config": "^4.1.0",
85+
"@babel/core": "^7.24.4",
86+
"@sinonjs/eslint-config": "^5.0.3",
8787
"@sinonjs/eslint-plugin-no-prototype-methods": "^0.1.1",
88-
"@sinonjs/referee": "^10.0.1",
89-
"@studio/changes": "^2.2.0",
88+
"@sinonjs/referee": "^11.0.1",
89+
"@studio/changes": "^3.0.0",
9090
"babel-plugin-istanbul": "^6.1.1",
9191
"babelify": "^10.0.0",
9292
"browserify": "^16.5.2",
9393
"debug": "^4.3.4",
9494
"dependency-check": "^4.1.0",
95-
"lint-staged": "^15.0.2",
96-
"mocha": "^10.2.0",
95+
"lint-staged": "^15.2.2",
96+
"mocha": "^10.4.0",
9797
"mochify": "^9.2.0",
9898
"nyc": "^15.1.0",
99-
"prettier": "^3.0.3",
100-
"puppeteer": "^21.4.0",
99+
"prettier": "^3.2.5",
100+
"puppeteer": "^22.7.1",
101101
"rimraf": "^5.0.5",
102-
"semver": "^7.5.4",
102+
"semver": "^7.6.0",
103103
"shelljs": "^0.8.5",
104-
"unimported": "^1.30.0"
104+
"unimported": "^1.31.0"
105105
},
106106
"files": [
107107
"lib",

test/es2015/module-support-assessment-test.mjs

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import sinon from "../../pkg/sinon-esm.js";
1919
const { assert, refute } = referee;
2020

2121
/**
22-
* @param action
22+
* @param action {string} the export on the `sinon` namespace to test
2323
*/
2424
function createTestSuite(action) {
2525
var stub;

test/issues/issues-test.js

+1
Original file line numberDiff line numberDiff line change
@@ -681,6 +681,7 @@ describe("issues", function () {
681681
};
682682

683683
let sandbox;
684+
684685
beforeEach(function () {
685686
sandbox = sinon.createStubInstance(Foo);
686687
});

test/proxy-call-test.js

+1
Original file line numberDiff line numberDiff line change
@@ -216,6 +216,7 @@ describe("sinonSpy.call", function () {
216216
describe("call.calledWithMatch", spyCallCalledTests("calledWithMatch"));
217217
// eslint-disable-next-line mocha/no-setup-in-describe
218218
describe("call.notCalledWith", spyCallNotCalledTests("notCalledWith"));
219+
219220
describe(
220221
"call.notCalledWithMatch",
221222
// eslint-disable-next-line mocha/no-setup-in-describe

test/proxy-test.js

+1
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ describe("proxy", function () {
4343
});
4444
assert.equals(named.printf("%n"), "cool");
4545
});
46+
4647
it("anon", function () {
4748
const anon = sinonSpy(function () {
4849
return;

test/spy-test.js

+2
Original file line numberDiff line numberDiff line change
@@ -1113,6 +1113,7 @@ describe("spy", function () {
11131113

11141114
// eslint-disable-next-line mocha/no-setup-in-describe
11151115
describe(".alwaysCalledWith", spyAlwaysCalledTests("alwaysCalledWith"));
1116+
11161117
describe(
11171118
".alwaysCalledWithMatch",
11181119
// eslint-disable-next-line mocha/no-setup-in-describe
@@ -1168,6 +1169,7 @@ describe("spy", function () {
11681169

11691170
// eslint-disable-next-line mocha/no-setup-in-describe
11701171
describe(".neverCalledWith", spyNeverCalledTests("neverCalledWith"));
1172+
11711173
describe(
11721174
".neverCalledWithMatch",
11731175
// eslint-disable-next-line mocha/no-setup-in-describe

test/stub-test.js

+1
Original file line numberDiff line numberDiff line change
@@ -1066,6 +1066,7 @@ describe("stub", function () {
10661066

10671067
describe("lazy instantiation of exceptions", function () {
10681068
let errorSpy;
1069+
10691070
beforeEach(function () {
10701071
this.originalError = globalContext.Error;
10711072
errorSpy = createSpy(globalContext, "Error");

0 commit comments

Comments
 (0)