ResourceClassGenerator always generates final fields

[hameno]

It seems that the old version of SymbolWriter from the android builder always writes the fields as final fields.
Updated to 2.2.3 the SymbolWriter class allows to specify whether to use final fields.

This should probably be fixed for aar libraries as their tests currently fail with robolectric 3.2.1 (see robolectric/robolectric#2847)

[hameno]

Tried updating to the newer 2.2.3 but I don't know how to fix ManifestMergerMojo, since that class seems to heavily depend on classes which are gone in 2.2.3

[Shusshu]

I can help you with that class. Do you have a branch with the ongoing changes?

[hameno]

Not yet, my "fix" was to always call the SymbolWriter in a way that does not use final fields, but that would be wrong. I'm not sure how I can detect if the generation is run during test lifecycle (and inside an aar library).

[hameno]

Pushed my minimal changes: https://github.com/sprylab/android-maven-plugin/tree/final_ids

[hameno]

I've created a WIP PR: #757

[Schlud]

Hi guys.
First of all thank you for your great work!

I've noticed that you are currently working on PR:#757
Do you now, if there is a pre-release version available for getting and testing the fixed state?

Thanks

[Shusshu]

You can build it locally and try it out. It would be good to know how it works for your use cases

[hameno]

Fixed with #757