Use Manifest Merger v2

[Shusshu]

Ticket to not forget the manifest merger v2

Have a flag to use the old manifest-merger default to the new one

Linked issue: #511

[Shusshu]

More info:
https://android.googlesource.com/platform/tools/base/+/master/build-system/builder/src/main/java/com/android/builder/core/AndroidBuilder.java

See method mergeManifests

[Shusshu]

I did some basic stuff here in a new Mojo:
https://github.com/simpligility/android-maven-plugin/tree/feature-manifest-merger-v2

Manifest Merger v2 user guide: http://tools.android.com/tech-docs/new-build-system/user-guide/manifest-merger

Everything you setup in your AndroidManifest with the tag tools should work

Setup used in my apk pom:

<sourceManifestFile>${project.basedir}/src/main/AndroidManifest.xml</sourceManifestFile>
<androidManifestFile>${project.build.directory}/AndroidManifest.xml</androidManifestFile>
<manifestMerger>
        <versionName>4.2.0-CUSTOM</versionName>
        <versionCode>42</versionCode>
        <usesSdk>
            <minSdkVersion>14</minSdkVersion>
            <targetSdkVersion>21</targetSdkVersion>
        </usesSdk>
</manifestMerger>

With that setup you don't need to modify your AndroidManifest on every release and commit it...
Everything is done in the pom!

[mosabua]

I think we can just remove the old one provided we have all features of the old one.

[Shusshu]

I don't think we'll have the same features for example the autoincrement won't be part of it I guess...

[mosabua]

autoincrement is useful imho. Setting same version as in pom is essential imho..

[Shusshu]

"Setting same version as in pom is essential imho.." that's part of it.

AutoIncrement isn't part of it.
Since we now take the manifest from the src folder process it using values from the pom and place it in the target folder how would you autoincrement it?