Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Denoise error messages for triple and presignature storage #90

Closed
ChaoticTempest opened this issue Jan 7, 2025 · 0 comments · Fixed by #122
Closed

Denoise error messages for triple and presignature storage #90

ChaoticTempest opened this issue Jan 7, 2025 · 0 comments · Fixed by #122

Comments

@ChaoticTempest
Copy link
Contributor

Currently with how error messages are being handle by storage, they are quite noisy, especially in the case of stockpiling not being present.

With lua runtime + redis, the error category is the first word that appears in the error message, so we have a way to classify the error message, even though we have to write the parser ourselves.

for example, our error message of Mine presignature stockpile does not have enough presignatures appears like the following where a : is inserted right after Mine such that we can specifically only call debug on stockpile low instead of warn or error. These don't do much in the sense of actual warnings or errors, so it's better to just leave them for alerts in grafana

2025-01-07T23:29:29.110370Z ERROR ThreadId(03) mpc_node::protocol::presignature: failed to look for mine presignature e=Redis(Mine: presignature stockpile does not have enough presignatures)
2025-01-07T23:29:29.111532Z  WARN ThreadId(03) mpc_node::protocol::triple: failed to take two mine triples store_error=Redis(Mine: triple stockpile does not have enough triples)
2025-01-07T23:29:29.154251Z ERROR ThreadId(07) mpc_node::protocol::presignature: failed to look for mine presignature e=Redis(Mine: presignature stockpile does not have enough presignatures)
2025-01-07T23:29:29.169202Z  WARN ThreadId(08) mpc_node::protocol::triple: failed to take two mine triples store_error=Redis(Mine: triple stockpile does not have enough triples)
2025-01-07T23:29:29.183934Z ERROR ThreadId(09) mpc_node::protocol::presignature: failed to look for mine presignature e=Redis(Mine: presignature stockpile does not have enough presignatures)
2025-01-07T23:29:29.199993Z  WARN ThreadId(05) mpc_node::protocol::triple: failed to take two mine triples store_error=Redis(Mine: triple stockpile does not have enough triples)
2025-01-07T23:29:29.218561Z ERROR ThreadId(07) mpc_node::protocol::presignature: failed to look for mine presignature e=Redis(Mine: presignature stockpile does not have enough presignatures)
2025-01-07T23:29:29.219538Z  WARN ThreadId(02) mpc_node::protocol::triple: failed to take two mine triples store_error=Redis(Mine: triple stockpile does not have enough triples)
2025-01-07T23:29:29.264320Z ERROR ThreadId(06) mpc_node::protocol::presignature: failed to look for mine presignature e=Redis(Mine: presignature stockpile does not have enough presignatures)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant