Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check is_stable per chain not just NEAR network #137

Open
ChaoticTempest opened this issue Jan 23, 2025 · 2 comments
Open

Check is_stable per chain not just NEAR network #137

ChaoticTempest opened this issue Jan 23, 2025 · 2 comments

Comments

@ChaoticTempest
Copy link
Contributor

Since we have ETH indexing now, we should check the stability of eth alongside NEAR as well.

The main point of attention would be when and where to publish a signature based on the chain. So when a new request is received by SignatureManager we should sort the stable participants based on chain and their equivalent indexer is_stable condition.

Right now, we publish StateView::Running { is_stable, .. } where is_stable is from NEAR network. We need a way to add in eth as well. Maybe something like this additional field would suffice:

StateView::{Running, Resharing} {
   chains: Map<Chain, ChainInfo>
}

struct ChainInfo {
    latest_block_height: u64,
    is_stable: bool,
    // other chain related info
    ..
}

And then when we go to organize our requests, we can then utilize this info for better handling

@volovyks
Copy link
Contributor

We will have many more chains soon. I'm not sure if adding additional parameters to the structure is the best idea, but I agree that we need to distinguish them.

@ChaoticTempest
Copy link
Contributor Author

how else would we distinguish stable participants then? We need a way to provide this info somehow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants