Skip to content
This repository was archived by the owner on Mar 14, 2023. It is now read-only.

Added event after the ssh pool is setup #230

Merged
merged 4 commits into from
Mar 1, 2019

Conversation

delmendo
Copy link
Contributor

The current emit(init) happens too early. In order to improve configuration options for the shipit-bastion I need a hook after the pool is setup so I can modify it with the options for the proxy I'm inserting. This should not impact any current users but should make shipit more flexible.

@gregberge
Copy link
Member

Hello @delmendo, are you sure that you can't plug you anywhere else? If not, we still have to document it. Can you add a line about it in the readme? Thanks!

@delmendo
Copy link
Contributor Author

delmendo commented Feb 26, 2019

I looked at taking over the initialization of the ssh pool itself but the code that exists doesn't check to see if the pool has already been setup. This seemed the lightest way possible to get the stage I needed (The pool has been setup by the main system and won't be overridden by the main package). I tried to make it so that it would do the least possible change to the core project.

I added in documentation for the emit events and a note about the other events that are hooked into by the cli through orchestrator (Since I didn't seem them covered anywhere else). Please let me know if I need to do anything else.

@gregberge
Copy link
Member

OK thanks, @delmendo tests are broken, can you try to fix them?

@delmendo
Copy link
Contributor Author

delmendo commented Feb 28, 2019

I added tests for the emit methods (the one I added and the one that was already there). Looks like the build is now clean :)

Added in a test for the init:after_ssh_pool
@gregberge gregberge merged commit e864338 into shipitjs:master Mar 1, 2019
@gregberge
Copy link
Member

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants