Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graphical interface for dot #85

Merged
merged 18 commits into from
Jul 10, 2023
Merged

Graphical interface for dot #85

merged 18 commits into from
Jul 10, 2023

Conversation

Ghassen-Chaabouni
Copy link
Contributor

@Ghassen-Chaabouni Ghassen-Chaabouni commented Jul 3, 2023 •
edited
Loading

Description

This PR adds a graphical interface for dot.

To test it run python src/dot/ui/ui.py

gui_dot_demo

Changelog:

Added:

  • src/dot/ui/ui.py a graphical interface for dot using tkinter and customtkinter

Updated:

  • Path of CACHED_PREDICTOR_PATH

@Ghassen-Chaabouni Ghassen-Chaabouni added the feature New feature or request label Jul 3, 2023
@Ghassen-Chaabouni Ghassen-Chaabouni self-assigned this Jul 3, 2023
ajndkr
ajndkr reviewed Jul 3, 2023
View reviewed changes
Copy link
Member

@ajndkr ajndkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. please update readme with usage instructions.

@ajndkr
Copy link
Member

ajndkr commented Jul 3, 2023

@Ghassen-Chaabouni can you also resolve all dependabot alerts in this pr? https://github.com/sensity-ai/dot/security/dependabot

@Ghassen-Chaabouni
Copy link
Contributor Author

@Ghassen-Chaabouni can you also resolve all dependabot alerts in this pr? https://github.com/sensity-ai/dot/security/dependabot

I think it would be better to resolve them in a seperate PR

@Ghassen-Chaabouni Ghassen-Chaabouni marked this pull request as ready for review July 3, 2023 12:09
@Ghassen-Chaabouni Ghassen-Chaabouni requested a review from ajndkr July 3, 2023 12:10
@Ghassen-Chaabouni
Copy link
Contributor Author

looks good. please update readme with usage instructions.

I added the instructions

ajndkr
ajndkr reviewed Jul 3, 2023
View reviewed changes
ajndkr
ajndkr reviewed Jul 3, 2023
View reviewed changes
@vassilispapadop
Copy link
Contributor

vassilispapadop commented Jul 4, 2023 •
edited
Loading

@Ghassen-Chaabouni the DOT-GUI seems to work fine on Apple-M2. Though, we need to change requirements file to setup the environment for M2(out of PR's scope).

Screenshot 2023-07-04 at 3 07 10 PM

@Ghassen-Chaabouni Ghassen-Chaabouni requested a review from ajndkr July 10, 2023 10:31
ajndkr
ajndkr reviewed Jul 10, 2023
View reviewed changes
Copy link
Member

@ajndkr ajndkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I still think the usage instructions in the readme are not sufficient. best to explicitly mention specific instructions for users.

@Ghassen-Chaabouni
Copy link
Contributor Author

lgtm. I still think the usage instructions in the readme are not sufficient. best to explicitly mention specific instructions for users.

I added a usage example in the README

@Ghassen-Chaabouni Ghassen-Chaabouni requested a review from ajndkr July 10, 2023 12:52
ajndkr
ajndkr approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@ajndkr ajndkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@giorgiop @vassilispapadop okay to merge?

@vassilispapadop
Copy link
Contributor

@giorgiop @vassilispapadop okay to merge?

Lgtm

giorgiop
giorgiop requested changes Jul 10, 2023
View reviewed changes
@Ghassen-Chaabouni Ghassen-Chaabouni merged commit 844003e into main Jul 10, 2023
@Ghassen-Chaabouni Ghassen-Chaabouni deleted the feature/dot-graphical-interface branch July 10, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giorgiop giorgiop giorgiop approved these changes

@ajndkr ajndkr ajndkr approved these changes

@vassilispapadop vassilispapadop Awaiting requested review from vassilispapadop

Assignees

@Ghassen-Chaabouni Ghassen-Chaabouni

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ghassen-Chaabouni @ajndkr @vassilispapadop @giorgiop