Add Feature to Use Config Files #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 🐛 minor bugfix - 📝 minor doc updates
ajndkr
added
documentation
|
Do we want to update also the script without camera, so that they can run using the configs? |
|
Sure I will update the doc. |
|
Are we solving this path issues too? #12 (comment) |
Nope. I think it should be handled in a different PR. I believe @Ghassen-Chaabouni might already be working on this. I'll create a new issue to resolve this. |
ghassen1302
suggested changes
Jun 13, 2022
ghassen1302
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new feature to use config file to load pass model checkpoint paths when running dot.
This feature update maintains backward compatibility with existing CLI options. If a config file is passed, only selective parameters are overriden by the loaded config dictionary.
Closes #4.
Changelog
Added:
dot.__main__.main()Updated: