Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Minuit instance to FitResults #503

Open
alexander-held opened this issue Feb 12, 2025 · 2 comments · May be fixed by #504
Open

Add Minuit instance to FitResults #503

alexander-held opened this issue Feb 12, 2025 · 2 comments · May be fixed by #504
Assignees
Labels
enhancement New feature or request

Comments

@alexander-held
Copy link
Member

Adding the iminuit.Minuit instance to the FitResults container would allow interacting with that directly to access more of the iminuit functionality. This could be useful if users want to run other steps after a fit and would work similarly to return_result_obj=True in pyhf.infer.mle.fit.

@alexander-held alexander-held added the enhancement New feature or request label Feb 12, 2025
@MoAly98
Copy link
Collaborator

MoAly98 commented Feb 13, 2025

Hi @alexander-held, is this deeper than updating the class for FitResults and adding the instance returned from the fit? Just not sure what you intend by specifying that it would work similarly to the return_result_obj=True -- do you mean it should be optional?

I'm happy to be assigned this issue.

@alexander-held
Copy link
Member Author

alexander-held commented Feb 13, 2025

Great, thanks for helping with this! Thinking about it a bit more, I see no downside to just always adding it to FitResults so we don't need to make this optional. The difference with pyhf is that the fit function there returns a varying amount of objects depending on its keyword arguments but we always only return a single FitResults object so users who do not need that Minuit instance can just ignore it.

@MoAly98 MoAly98 linked a pull request Feb 13, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants