Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust Updated libbpf-rs & libbpf-cargo to 0.24 #436

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

danielocfb
Copy link

Use updated libbpf-rs & libbpf-cargo. Generated skeletons now contain directly accessible map and program objects, no longer necessitating the use of accessor methods. As a result, the risk for mutability conflicts is reduced greatly.

Update libbpf-rs & libbpf-cargo to 0.24. Among other things, generated
skeletons now contain directly accessible map and program objects, no
longer necessitating the use of accessor methods. As a result, the risk
for mutability conflicts is reduced greatly.

Signed-off-by: Daniel Müller <[email protected]>
@danielocfb danielocfb force-pushed the topic/inlined-skeleton-members branch 4 times, most recently from 52a9971 to 5007453 Compare July 17, 2024 18:01
@danielocfb
Copy link
Author

Not going to un-draft this until the next libbpf-rs release is cut (which could take a while). We could land it as-is conceptually, but I suspect you guys don't want to depend on a random libbpf-rs snapshot, as that would block any attempt of publishing your crates.

@danielocfb danielocfb force-pushed the topic/inlined-skeleton-members branch 2 times, most recently from 166774b to bd2af27 Compare August 6, 2024 20:42
@danielocfb danielocfb force-pushed the topic/inlined-skeleton-members branch from bd2af27 to db04ee9 Compare August 7, 2024 21:45
@danielocfb danielocfb changed the title [TESTING ONLY] rust: Use updated libbpf-rs & libbpf-cargo rust Updated libbpf-rs & libbpf-cargo to 0.24 Aug 7, 2024
@danielocfb danielocfb marked this pull request as ready for review August 7, 2024 21:50
@danielocfb
Copy link
Author

Not going to un-draft this until the next libbpf-rs release is cut

0.24.0 is out, so I think this change can be reviewed now.

@danielocfb
Copy link
Author

Please wait with merge a little longer. Still investigating a potential issue.

@danielocfb danielocfb marked this pull request as draft August 8, 2024 15:33
@danielocfb danielocfb force-pushed the topic/inlined-skeleton-members branch from db04ee9 to 565aec3 Compare August 8, 2024 18:04
@danielocfb danielocfb marked this pull request as ready for review August 8, 2024 18:04
@danielocfb
Copy link
Author

Please wait with merge a little longer. Still investigating a potential issue.

We should be good now.

@htejun htejun merged commit b264787 into sched-ext:main Aug 9, 2024
1 check passed
@htejun
Copy link
Contributor

htejun commented Aug 9, 2024

FYI, @danielocfb for some reason, your commit's commit date is earlier than its parent and tig has trouble rendering it correctly.

@danielocfb danielocfb deleted the topic/inlined-skeleton-members branch August 12, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants