Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for patterns matching Conventional Commit types for bu… #179

Merged
merged 2 commits into from
Mar 16, 2023

Conversation

dkichler
Copy link
Contributor

@dkichler dkichler commented Mar 14, 2023

…mping versions

Taking some of the feedback garnered on #91, this PR provides a more gentle introduction of conventional commits. Reused a portion of the scripted tests written for that PR since they apply equally to this implementation (thanks @jrouly).

Implements Conventional Commit bump patterns as an opt-in plugin. This way existing users will be unaffected but can take advantage of these patterns if they so wish.

Addresses #180

…ping versions. Adding dyn-ver plugin. Upgrading to sbt 1.8.2.
@dkichler dkichler force-pushed the conventional-commits branch from b295e3e to 983cc71 Compare March 14, 2023 15:59
Copy link

@reid-spencer reid-spencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM .. I just have a couple questions for you to consider.

…be toggled to singular via a new setting key 'conventionalPatternsAdditive'
Copy link

@reid-spencer reid-spencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dkichler dkichler merged commit 96e1a59 into master Mar 16, 2023
@dkichler dkichler deleted the conventional-commits branch March 16, 2023 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants