Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start Linting Under Py3 #55500

Merged
merged 61 commits into from
Jan 4, 2020
Merged

Start Linting Under Py3 #55500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
61 commits
Select commit Hold shift + click to select a range
0bec059
Start linting under Py3
s0undt3ch Dec 3, 2019
bf54d58
Delete `.testing.pylintrc`. Use msg ids instead of msg codes.
s0undt3ch Dec 3, 2019
e92082e
Upgrade to latest PyLint
s0undt3ch Dec 3, 2019
98afee1
Update `.pylintrc` to latest default from PyLint
s0undt3ch Dec 3, 2019
b3b3f43
Remove custom lint flags from pylint sessions. Lint fix.
s0undt3ch Dec 3, 2019
594128f
Start ignoring `import-outside-toplevel`. Unfortunately we need defer…
s0undt3ch Dec 3, 2019
c504361
"Tee" the pylint output instead of echoing it at the end
s0undt3ch Dec 3, 2019
a7da183
Switch pipelines to master-1.6
s0undt3ch Dec 3, 2019
c314ca3
Pass as keyword argument. Fixes wrong argument order.
s0undt3ch Dec 3, 2019
5fe8d37
Don't catch `ImportError` to raise it right after
s0undt3ch Dec 3, 2019
f0bc3d7
PyLint disable `try-except-raise`
s0undt3ch Dec 3, 2019
93b92c0
Don't catch exceptions only to raise them right after
s0undt3ch Dec 3, 2019
1f99de9
PyLint disable `keyword-arg-before-vararg`
s0undt3ch Dec 3, 2019
03ecce2
Fix PyLint `unnecessary-pass`
s0undt3ch Dec 3, 2019
8ead47d
Fix PyLint `len-as-condition`
s0undt3ch Dec 3, 2019
b0405a6
Fix/ignore Pylint `undefined-variable`
s0undt3ch Dec 3, 2019
4d5ca64
Fix PyLint `logging-not-lazy`
s0undt3ch Dec 3, 2019
870a733
Fix PyLint `unsupported-assignment-operation`
s0undt3ch Dec 3, 2019
6513c84
Fix PyLint `bad-option-value`
s0undt3ch Dec 3, 2019
f6dabc4
Fix PyLint `unneeded-not`
s0undt3ch Dec 3, 2019
5419754
Fix PyLint `possibly-unused-variable`
s0undt3ch Dec 3, 2019
b3f48a9
Ignore PyLint `possibly-unused-variable`
s0undt3ch Jan 3, 2020
eeea9d9
Fix PyLint `unused-import`
s0undt3ch Dec 3, 2019
fce524e
Fix PyLint `duplicate-string-formatting-argument`
s0undt3ch Dec 3, 2019
7a543cd
For now, globaly ignore `deprecated-method`
s0undt3ch Dec 3, 2019
420be98
Fix PyLint `useless-import-alias`
s0undt3ch Dec 3, 2019
e35546c
Ignore PyLint `useless-super-delegation`
s0undt3ch Dec 3, 2019
07c0f22
Fix PyLint `incompatible-py3-code`
s0undt3ch Dec 3, 2019
05e4ebc
Fix PyLint `invalid-name`
s0undt3ch Dec 3, 2019
6fca5e5
Fix PyLint `arguments-differ`
s0undt3ch Dec 3, 2019
4a7b64f
Fox now, disable PyLint `keyword-arg-before-vararg`
s0undt3ch Dec 3, 2019
080589c
Fix PyLint `bad-super-call`
s0undt3ch Dec 3, 2019
af25747
Fix PyLint `raising-format-tuple`
s0undt3ch Dec 3, 2019
d6324a3
Fix PyLint `not-callable`
s0undt3ch Dec 4, 2019
17f5ba0
Fix PyLint `no-name-in-module`
s0undt3ch Dec 4, 2019
8f50a88
Fix PyLint `consider-iterating-dictionary`
s0undt3ch Dec 4, 2019
dddf635
Fix PyLint `self-assigning-variable`
s0undt3ch Dec 4, 2019
9fbae13
Ignore PyLint `too-many-function-args`
s0undt3ch Dec 4, 2019
47b2c8e
Fix PyLint `dangerous-default-value`
s0undt3ch Dec 4, 2019
8beb40e
Fix PyLint `dict-iter-missing-items`
s0undt3ch Dec 4, 2019
b65b9ea
Fix PyLint `assignment-from-no-return`
s0undt3ch Dec 4, 2019
91839cd
Why make something so simple so unreadble?! Fixes PyLint `cell-var-fr…
s0undt3ch Dec 4, 2019
8f3a5dc
Fix PyLint `unbalanced-tuple-unpacking`
s0undt3ch Dec 4, 2019
fa0d964
Fix PyLint `not-an-iterable`
s0undt3ch Dec 4, 2019
5ffc073
Use `setUpClass` instead. Fixes PyLint `bad-super-call`
s0undt3ch Dec 4, 2019
b0fb204
Remove useless `__init__`. Fixes PyLint `useless-super-delegation`
s0undt3ch Dec 4, 2019
f61bd40
Fix PyLint `unsupported-membership-test`
s0undt3ch Dec 4, 2019
d443e6a
Fix PyLint `redundant-keyword-arg`
s0undt3ch Dec 4, 2019
6054e06
Fix PyLint `unsupported-delete-operation`
s0undt3ch Dec 4, 2019
6c76f4e
Ignore PyLint `duplicate-except`
s0undt3ch Dec 4, 2019
9577efc
Fix PyLint `possibly-unused-variable`
s0undt3ch Dec 4, 2019
35646c5
Fix PyLint `broad-except`
s0undt3ch Jan 2, 2020
9fc821f
Fix PyLint `assignment-from-none`
s0undt3ch Jan 2, 2020
9aae525
Fix PyLint `duplicate-except`
s0undt3ch Jan 2, 2020
d591be7
Fix PyLint `too-many-function-args`
s0undt3ch Jan 2, 2020
af4664e
Remove useless `setUp`. Fixes PyLint `useless-super-delegation`
s0undt3ch Jan 2, 2020
267b91b
Fix PyLint `unbalanced-tuple-unpacking`
s0undt3ch Jan 2, 2020
c1c8ed9
Fix PyLint `useless-import-alias`
s0undt3ch Jan 2, 2020
bea7f90
Ignore PyLint `no-value-for-parameter`
s0undt3ch Jan 3, 2020
a79891c
Fix PyLint `using-constant-test`
s0undt3ch Jan 3, 2020
02d1a7d
Have nox reuse pre-commit's virtualenv
s0undt3ch Jan 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion .ci/docs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runDocs(
env: env)
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-amazon1-py2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 1,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-amazon2-py2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 1,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-amazon2-py3
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 1,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-archlts-py2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 1,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-archlts-py3
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 1,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-centos6-py2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 1,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-centos7-py2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 1,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-centos7-py2-cloud
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 0,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-centos7-py2-m2crypto
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 1,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-centos7-py2-proxy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 1,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-centos7-py2-pycryptodomex
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 1,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-centos7-py2-tcp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 1,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-centos7-py2-tornado
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 1,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-centos7-py3
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 1,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-centos7-py3-cloud
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 0,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-centos7-py3-m2crypto
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 1,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-centos7-py3-proxy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 1,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-centos7-py3-pycryptodomex
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 1,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-centos7-py3-tcp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 1,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-centos8-py3
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 1,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-debian10-py3
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 1,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-debian8-py2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 1,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-debian9-py2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 1,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-debian9-py3
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 1,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-fedora30-py2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 1,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-fedora30-py3
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 1,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-fedora31-py3
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 1,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-macosxhighsierra-py2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

// Pre-nox pipeline
runTestSuite(
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-macosxhighsierra-py3
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

// Pre-nox pipeline
runTestSuite(
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-macosxmojave-py2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

// Pre-nox pipeline
runTestSuite(
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-macosxmojave-py3
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

// Pre-nox pipeline
runTestSuite(
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-macosxsierra-py2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

// Pre-nox pipeline
runTestSuite(
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-macosxsierra-py3
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

// Pre-nox pipeline
runTestSuite(
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-opensuse15-py2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 1,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-opensuse15-py3
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 1,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-ubuntu1604-py2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 1,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-ubuntu1604-py2-m2crypto
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 1,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-ubuntu1604-py2-proxy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 1,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-ubuntu1604-py2-pycryptodomex
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 1,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-ubuntu1604-py2-tcp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 1,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-ubuntu1604-py2-tornado
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 1,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-ubuntu1604-py3
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 1,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-ubuntu1604-py3-m2crypto
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 1,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-ubuntu1604-py3-proxy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 1,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-ubuntu1604-py3-pycryptodomex
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 1,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-ubuntu1604-py3-tcp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 1,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-ubuntu1804-py2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 1,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-ubuntu1804-py3
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 1,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-windows2016-py2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 1,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-windows2016-py3
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 1,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-windows2019-py2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 1,
Expand Down
2 changes: 1 addition & 1 deletion .ci/kitchen-windows2019-py3
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runTestSuite(
concurrent_builds: 1,
Expand Down
2 changes: 1 addition & 1 deletion .ci/lint
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@Library('salt@master-1.5') _
@Library('salt@master-1.6') _

runLint(
env: env)
Expand Down
Loading