Code

Start Linting Under Py3#55500

Code

Merged

dwoz merged 61 commits intosaltstack:mastersaltstack/salt:masterfrom s0undt3ch:hotfix/bump-saltpylints0undt3ch/salt:hotfix/bump-saltpylintCopy head branch name to clipboardJan 4, 2020

+2,362-2,735

Commits

Commits on Jan 3, 2020

• Start linting under Py3

  s0undt3ch

  committed
  0bec059

  Copy full SHA for 0bec059

• Delete .testing.pylintrc. Use msg ids instead of msg codes.

  s0undt3ch

  committed
  bf54d58

  Copy full SHA for bf54d58

• Upgrade to latest PyLint

  s0undt3ch

  committed
  e92082e

  Copy full SHA for e92082e

• Update .pylintrc to latest default from PyLint

  s0undt3ch

  committed
  98afee1

  Copy full SHA for 98afee1

• Remove custom lint flags from pylint sessions. Lint fix.

  s0undt3ch

  committed
  b3b3f43

  Copy full SHA for b3b3f43

• Start ignoring import-outside-toplevel. Unfortunately we need deferred imports.

  s0undt3ch

  committed
  594128f

  Copy full SHA for 594128f

• "Tee" the pylint output instead of echoing it at the end

  s0undt3ch

  committed
  c504361

  Copy full SHA for c504361

• Switch pipelines to master-1.6

  s0undt3ch

  committed
  a7da183

  Copy full SHA for a7da183

• Pass as keyword argument. Fixes wrong argument order.

  s0undt3ch

  committed
  c314ca3

  Copy full SHA for c314ca3

• Don't catch ImportError to raise it right after

  s0undt3ch

  committed
  5fe8d37

  Copy full SHA for 5fe8d37

• PyLint disable try-except-raise

  s0undt3ch

  committed
  f0bc3d7

  Copy full SHA for f0bc3d7

• Don't catch exceptions only to raise them right after

  s0undt3ch

  committed
  93b92c0

  Copy full SHA for 93b92c0

• PyLint disable keyword-arg-before-vararg

  s0undt3ch

  committed
  1f99de9

  Copy full SHA for 1f99de9

• Fix PyLint unnecessary-pass

  s0undt3ch

  committed
  03ecce2

  Copy full SHA for 03ecce2

• Fix PyLint len-as-condition

  s0undt3ch

  committed
  8ead47d

  Copy full SHA for 8ead47d

• Fix/ignore Pylint undefined-variable

  s0undt3ch

  committed
  b0405a6

  Copy full SHA for b0405a6

• Fix PyLint logging-not-lazy

  s0undt3ch

  committed
  4d5ca64

  Copy full SHA for 4d5ca64

• Fix PyLint unsupported-assignment-operation

  s0undt3ch

  committed
  870a733

  Copy full SHA for 870a733

• Fix PyLint bad-option-value

  s0undt3ch

  committed
  6513c84

  Copy full SHA for 6513c84

• Fix PyLint unneeded-not

  s0undt3ch

  committed
  f6dabc4

  Copy full SHA for f6dabc4

• Fix PyLint possibly-unused-variable

  s0undt3ch

  committed
  5419754

  Copy full SHA for 5419754

• Ignore PyLint possibly-unused-variable

  s0undt3ch

  committed
  b3f48a9

  Copy full SHA for b3f48a9

• Fix PyLint unused-import

  s0undt3ch

  committed
  eeea9d9

  Copy full SHA for eeea9d9

• Fix PyLint duplicate-string-formatting-argument

  s0undt3ch

  committed
  fce524e

  Copy full SHA for fce524e

• For now, globaly ignore deprecated-method

  s0undt3ch

  committed
  7a543cd

  Copy full SHA for 7a543cd

• Fix PyLint useless-import-alias

  s0undt3ch

  committed
  420be98

  Copy full SHA for 420be98

• Ignore PyLint useless-super-delegation

  s0undt3ch

  committed
  e35546c

  Copy full SHA for e35546c

• Fix PyLint incompatible-py3-code

  s0undt3ch

  committed
  07c0f22

  Copy full SHA for 07c0f22

• Fix PyLint invalid-name

  s0undt3ch

  committed
  05e4ebc

  Copy full SHA for 05e4ebc

• Fix PyLint arguments-differ

  s0undt3ch

  committed
  6fca5e5

  Copy full SHA for 6fca5e5

• Fox now, disable PyLint keyword-arg-before-vararg

  s0undt3ch

  committed
  4a7b64f

  Copy full SHA for 4a7b64f

• Fix PyLint bad-super-call

  s0undt3ch

  committed
  080589c

  Copy full SHA for 080589c

• Fix PyLint raising-format-tuple

  s0undt3ch

  committed
  af25747

  Copy full SHA for af25747

• Fix PyLint not-callable

  s0undt3ch

  committed
  d6324a3

  Copy full SHA for d6324a3

• Fix PyLint no-name-in-module

  s0undt3ch

  committed
  17f5ba0

  Copy full SHA for 17f5ba0

• Fix PyLint consider-iterating-dictionary

  s0undt3ch

  committed
  8f50a88

  Copy full SHA for 8f50a88

• Fix PyLint self-assigning-variable

  s0undt3ch

  committed
  dddf635

  Copy full SHA for dddf635

• Ignore PyLint too-many-function-args

  s0undt3ch

  committed
  9fbae13

  Copy full SHA for 9fbae13

• Fix PyLint dangerous-default-value

  s0undt3ch

  committed
  47b2c8e

  Copy full SHA for 47b2c8e

• Fix PyLint dict-iter-missing-items

  s0undt3ch

  committed
  8beb40e

  Copy full SHA for 8beb40e

• Fix PyLint assignment-from-no-return

  s0undt3ch

  committed
  b65b9ea

  Copy full SHA for b65b9ea

• Why make something so simple so unreadble?! Fixes PyLint cell-var-from-loop

  s0undt3ch

  committed
  91839cd

  Copy full SHA for 91839cd

• Fix PyLint unbalanced-tuple-unpacking

  s0undt3ch

  committed
  8f3a5dc

  Copy full SHA for 8f3a5dc

• Fix PyLint not-an-iterable

  s0undt3ch

  committed
  fa0d964

  Copy full SHA for fa0d964

• Use setUpClass instead. Fixes PyLint bad-super-call

  s0undt3ch

  committed
  5ffc073

  Copy full SHA for 5ffc073

• Remove useless __init__. Fixes PyLint useless-super-delegation

  s0undt3ch

  committed
  b0fb204

  Copy full SHA for b0fb204

• Fix PyLint unsupported-membership-test

  s0undt3ch

  committed
  f61bd40

  Copy full SHA for f61bd40

• Fix PyLint redundant-keyword-arg

  s0undt3ch

  committed
  d443e6a

  Copy full SHA for d443e6a

• Fix PyLint unsupported-delete-operation

  s0undt3ch

  committed
  6054e06

  Copy full SHA for 6054e06

• Ignore PyLint duplicate-except

  s0undt3ch

  committed
  6c76f4e

  Copy full SHA for 6c76f4e

• Fix PyLint possibly-unused-variable

  s0undt3ch

  committed
  9577efc

  Copy full SHA for 9577efc

• Fix PyLint broad-except

  s0undt3ch

  committed
  35646c5

  Copy full SHA for 35646c5

• Fix PyLint assignment-from-none

  s0undt3ch

  committed
  9fc821f

  Copy full SHA for 9fc821f

• Fix PyLint duplicate-except

  s0undt3ch

  committed
  9aae525

  Copy full SHA for 9aae525

• Fix PyLint too-many-function-args

  s0undt3ch

  committed
  d591be7

  Copy full SHA for d591be7

• Remove useless setUp. Fixes PyLint useless-super-delegation

  s0undt3ch

  committed
  af4664e

  Copy full SHA for af4664e

• Fix PyLint unbalanced-tuple-unpacking

  s0undt3ch

  committed
  267b91b

  Copy full SHA for 267b91b

• Fix PyLint useless-import-alias

  s0undt3ch

  committed
  c1c8ed9

  Copy full SHA for c1c8ed9

• Ignore PyLint no-value-for-parameter

  s0undt3ch

  committed
  bea7f90

  Copy full SHA for bea7f90

• Fix PyLint using-constant-test

  s0undt3ch

  committed
  a79891c

  Copy full SHA for a79891c

• Have nox reuse pre-commit's virtualenv

  s0undt3ch

  committed
  02d1a7d

  Copy full SHA for 02d1a7d