Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3006.x] Make sure the root minion process handles SIGUSR1 #66095

Merged
merged 2 commits into from
Jul 18, 2024
Merged

[3006.x] Make sure the root minion process handles SIGUSR1 #66095

merged 2 commits into from
Jul 18, 2024

Conversation

max-arnold
Copy link
Contributor

@max-arnold max-arnold commented Feb 19, 2024 •
edited
Loading

What does this PR do?

Makes the root minion process handle SIGUSR1 as described here https://docs.saltproject.io/en/latest/topics/troubleshooting/minion.html#live-python-debug-output

What issues does this PR fix or reference?

References: #1241

Previous Behavior

Minion dies:

kill -USR1 $(pgrep -fw salt-minion | head -1)

salt-minion
zsh: user-defined signal 1  salt-minion
[ERROR   ] Minion process encountered exception: [Errno 3] No such process

New Behavior

Sending SIGUSR1 prints a traceback

Merge requirements satisfied?

Commits signed with GPG?

No

@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Make sure the root minion process handles SIGUSR1 [master] Make sure the root minion process handles SIGUSR1 Feb 19, 2024
@max-arnold max-arnold force-pushed the minion-sigusr branch 2 times, most recently from 378f806 to ef07978 Compare February 19, 2024 18:10
@max-arnold max-arnold marked this pull request as ready for review February 19, 2024 18:11
@max-arnold max-arnold requested a review from a team as a code owner February 19, 2024 18:11
@max-arnold max-arnold requested review from whytewolf and removed request for a team February 19, 2024 18:11
@whytewolf
Copy link
Collaborator

we are going to need a test on this. just something that tests the process does do what is expected for sigusr1

@dwoz dwoz changed the base branch from master to 3006.x July 17, 2024 22:08
@dwoz dwoz requested a review from a team as a code owner July 17, 2024 22:08
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title [master] Make sure the root minion process handles SIGUSR1 [3006.x] Make sure the root minion process handles SIGUSR1 Jul 17, 2024
@dwoz dwoz modified the milestones: Argon v3008.0, Sulfur v3006.9 Jul 17, 2024
dmurphy18
dmurphy18 previously approved these changes Jul 18, 2024
View reviewed changes
twangboy
twangboy previously approved these changes Jul 18, 2024
View reviewed changes
@dwoz dwoz dismissed stale reviews from twangboy and dmurphy18 via 8aca8d7 July 18, 2024 20:40
@dwoz dwoz merged commit 84b4e96 into saltstack:3006.x Jul 18, 2024
251 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twangboy twangboy twangboy approved these changes

@dmurphy18 dmurphy18 dmurphy18 left review comments

@whytewolf whytewolf Awaiting requested review from whytewolf whytewolf was automatically assigned from saltstack/team-core

Assignees
No one assigned
Labels
test:full Run the full test suite test:pkg Run the package tests
Projects
None yet
Milestone
Sulfur v3006.9
Development

Successfully merging this pull request may close these issues.
5 participants
@max-arnold @whytewolf @dwoz @twangboy @dmurphy18