fix: allow set cookies with localhost

colincasey · colincasey · commit ea0ea0ce42a8 · 2022-08-25T10:11:55.000-03:00
Adding more tests to cover the breaking use cases noted in #246. e.g.;. * `new CookieJar().setCookieSync("settingThisShouldPass=true; Domain=localhost; Path=/;", "http://localhost")` Also modifies the assertion for a test introduced in #221 that may be incorrect.
diff --git a/lib/pubsuffix-psl.js b/lib/pubsuffix-psl.js
@@ -60,7 +60,7 @@ function getPublicSuffix(domain, options = {}) {
 
   if (!ignoreError && SPECIAL_USE_DOMAINS.includes(topLevelDomain)) {
     if (allowSpecialUseDomain) {
-      return "";
+      return topLevelDomain;
     }
     throw new Error(
       `Cookie has domain set to the public suffix "${topLevelDomain}" which is a special use domain. To allow this, configure your CookieJar with {allowSpecialUseDomain:true, rejectPublicSuffixes: false}.`

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ function getPublicSuffix(domain, options = {}) {`
`60`	`60`
`61`	`61`	`if (!ignoreError && SPECIAL_USE_DOMAINS.includes(topLevelDomain)) {`
`62`	`62`	`if (allowSpecialUseDomain) {`
`63`		`- return "";`
	`63`	`+ return topLevelDomain;`
`64`	`64`	`}`
`65`	`65`	`throw new Error(`
`66`	`66`	`Cookie has domain set to the public suffix "${topLevelDomain}" which is a special use domain. To allow this, configure your CookieJar with {allowSpecialUseDomain:true, rejectPublicSuffixes: false}.`