Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests for utils #110

Merged
merged 1 commit into from
Nov 8, 2016
Merged

Add more tests for utils #110

merged 1 commit into from
Nov 8, 2016

Conversation

laanwj
Copy link
Contributor

@laanwj laanwj commented Nov 8, 2016

  • Add tests for html_parsing, proxycheck, random, remove_duplicates, url_parsing (everything that doesn't require networking)
  • Add a check to GenerateRandomBytes for negative values.

Increases coverage:

ok      github.com/s-rah/onionscan/utils        0.009s  coverage: 30.5% of statements
ok      github.com/s-rah/onionscan/utils        0.035s  coverage: 72.6% of statements

- Add tests for `html_parsing`, `proxycheck`, `random`,
  `remove_duplicates`, `url_parsing`

- Add a check to `GenerateRandomBytes` for negative values.
@coveralls
Copy link

coveralls commented Nov 8, 2016

Coverage Status

Coverage increased (+4.8%) to 31.103% when pulling 7608dca on laanwj:2016_11_util_tests into 751cc8a on s-rah:onionscan-0.3.

@s-rah s-rah merged commit e6999fa into s-rah:onionscan-0.3 Nov 8, 2016
@s-rah
Copy link
Owner

s-rah commented Nov 8, 2016

Awesome! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants