Fix libyaml download failure rescue under miniruby #562
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to build Ruby on a system without libyaml today and realized
that my attempt from #557 doesn't
fix the error in #552. I still got
the same LoadError from digest.
Since
LoadError
is not a StandardError, a plainrescue
doesn't catchit. Catch
LoadError
explicitly instead and reduce the scope of thebegin
block.I tested this change in a Ruby build on macOS without libyaml installed
and confirmed that
make
continues with a warning instead of aborting: