Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should validationInterval default to idleTimeout? #149

Closed
hadley opened this issue Jan 9, 2023 · 2 comments · Fixed by #162
Closed

Should validationInterval default to idleTimeout? #149

hadley opened this issue Jan 9, 2023 · 2 comments · Fixed by #162
Labels
feature a feature request or enhancement

Comments

@hadley
Copy link
Member

hadley commented Jan 9, 2023

It seems inconsistent that the first connection is only validated every 10 minutes, but subsequent connections will be destroyed and revalidated after 1 minute.
@hadley hadley added the feature a feature request or enhancement label Jan 9, 2023
@hadley
Copy link
Member Author

hadley commented Jan 27, 2023

No reason they need to be the same, but in the computational environment that pool seems to be used, making validateInterval smaller is a pragmatic choice.

@hadley
Copy link
Member Author

hadley commented Jan 27, 2023

What happens with validateInterval is 0? Does it kick off a background thread that is constantly revalidating?

hadley added a commit that referenced this issue Jan 29, 2023
@hadley
Decrease validationInterval
1501c1e 
Fixes #149
hadley added a commit that referenced this issue Feb 10, 2023
@hadley
Reduce default validationInternal to 1 minute
5c2c66d 
Fixes #149
@hadley hadley mentioned this issue Feb 10, 2023
Merged
hadley added a commit that referenced this issue Feb 10, 2023
@hadley
Shorter validation (#162)
37faf39 
Fixes #149
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature a feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Shorter validation rstudio/pool
1 participant
@hadley