CSI: Add support for CSIDriver object creation #4169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be helpful to list the CSI drivers deployed in the kubernetes cluster. if we have N number of CSI drivers deployed in the cluster, the user can query kubectl get csidriver and get the list of registered CSI drivers and it requires kube 1.14+ and also the functionality is disabled by default More info here: ceph/ceph-csi#698 Signed-off-by: Madhu Rajanna <[email protected]>
|
Added DNM label as this requires cephcsi 1.2.2 release |
5 tasks
leseb
reviewed
Oct 24, 2019
cephcsi is built for multiple CO not completely for kubernetes and this feature is specific to CO built around Kubernetes, that why we have not enabled by default in cephcsi. however, this will be enabled by default if cephcsi is deployed by rook and I have provided an option to turn it off in rook deployment |
leseb
approved these changes
Oct 24, 2019
|
Oops, I guess I merged it :-( @Madhu-1 should we revert? |
leseb
added a commit
to leseb/rook
that referenced
this pull request
Oct 24, 2019
I merged rook#4169 too quickly and didn't noticed we were supposed to wait for csi 1.2.2. This reverts commit 520ad44. Signed-off-by: Sébastien Han <[email protected]>
9 tasks
binoue
pushed a commit
to binoue/rook
that referenced
this pull request
Apr 10, 2020
I merged rook#4169 too quickly and didn't noticed we were supposed to wait for csi 1.2.2. This reverts commit 520ad44. Signed-off-by: Sébastien Han <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
This will be helpful to list the CSI drivers deployed in the kubernetes cluster. if we have N number of
CSI drivers deployed in the cluster, the user can query
kubectl get csidriverand get the list ofregistered CSI drivers and it requires kube 1.14+ and also the functionality is disabled by default
More info here: ceph/ceph-csi#698
Signed-off-by: Madhu Rajanna [email protected]
Which issue is resolved by this Pull Request:
Resolves #
Checklist:
make codegen) has been run to update object specifications, if necessary.[skip ci]