Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(api-status): add container status check #2159

Closed
wants to merge 1 commit into from
Closed

chore(api-status): add container status check #2159

wants to merge 1 commit into from
+52 −27

Conversation

NathanFlurry
Copy link
Member

Changes

@NathanFlurry
chore(api-status): add container status check

Verified

This commit was signed with the committer’s verified signature.
NathanFlurry Nathan Flurry
GPG key ID: 5A997507F286F2D8
Verified
Learn about vigilant mode
Loading
Loading status checks…
d15d889
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Mar 8, 2025 •
edited
Loading

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: d15d889
Status:🚫  Build failed.

View logs

@NathanFlurry Graphite App
Copy link
Member Author

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Mar 8, 2025 •
edited
Loading

Merge activity

  • Mar 8, 4:45 PM EST: A user added this pull request to the Graphite merge queue.
  • Mar 8, 4:46 PM EST: CI is running for this PR on a draft PR: #2160
  • Mar 8, 4:47 PM EST: A user merged this pull request with the Graphite merge queue via draft PR: #2160.

greptile-apps[bot]
greptile-apps bot reviewed Mar 8, 2025
View reviewed changes
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR adds container status check functionality alongside existing isolate checks by generalizing the configuration and routing structure.

  • Renamed actor_isolate.rs to actor.rs and added StatusQueryBuild enum to support both ws-isolate and ws-container builds
  • Renamed configuration keys from system_test_isolate_* to system_test_* across config files for more generic status check handling
  • Added container-specific resource specifications (CPU: 100, Memory: 128) in actor.rs for container builds
  • Simplified API routing from /actor/isolate to /actor to handle both types of status checks
  • Updated server spec schema to reflect renamed configuration properties while maintaining functionality

6 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

packages/core/api/status/src/route/actor.rs
#[derive(Debug, Serialize, Deserialize)]
enum StatusQueryBuild {
#[serde(rename = "ws-isolate")]
WsIsoalte,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntax: WsIsoalte is misspelled (should be WsIsolate)

Suggested change
WsIsoalte,
WsIsolate,

graphite-app bot pushed a commit that referenced this pull request Mar 8, 2025
@NathanFlurry
chore(api-status): add container status check (#2159)

Verified

This commit was signed with the committer’s verified signature.
NathanFlurry Nathan Flurry
GPG key ID: 6A5F43A4F3241BCA
Verified
Learn about vigilant mode
Loading
Loading status checks…
d1f57f4 
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@graphite-app graphite-app bot closed this Mar 8, 2025
@graphite-app graphite-app bot deleted the 03-08-chore_api-status_add_container_status_check branch March 8, 2025 21:47
@github-actions github-actions bot mentioned this pull request Mar 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greptile-apps greptile-apps[bot]

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@NathanFlurry