Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

await example #327

Open
mariusa opened this issue Sep 7, 2019 · 3 comments
Open

await example #327

mariusa opened this issue Sep 7, 2019 · 3 comments

Comments

@mariusa
Copy link

mariusa commented Sep 7, 2019

Would you please add an example to README on how to use request-promise with await ?

Thanks

@franck-romano
Copy link

franck-romano commented Oct 1, 2019

Hi,

I don't know if it relevant since async/await is specific to ES6 and not specific to request-promise.

What do you think about this ?

@mariusa
Copy link
Author

mariusa commented Oct 1, 2019

Hi Franck,

Looks like async/await is the best-practice to use JS calls going forward. It would ease the adoption of request-promise to have a clear example with this method.

Thanks for considering.

@franck-romano
Copy link

Completely agree with you, even if switching from promises to async/await is not painful.

I can add an example ASAP and make a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants