Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): test discover_public_ip does not unset var #5463

Merged
merged 3 commits into from
Nov 10, 2024
Merged

chore(ci): test discover_public_ip does not unset var #5463

merged 3 commits into from
Nov 10, 2024

Conversation

emosbaugh
Copy link
Member

@emosbaugh emosbaugh commented Nov 8, 2024 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Steps to reproduce

Does this PR introduce a user-facing change?

Fixes an issue when installing in AWS, GCP or Azure where the `public-address` passed into the install script via a flag by the end user may be overridden if an alternate is detected using the corresponding cloud provider metadata service.

Does this PR require documentation?

@emosbaugh emosbaugh requested a review from a team as a code owner November 8, 2024 21:41
@emosbaugh emosbaugh merged commit 51ee0c0 into main Nov 10, 2024
7 checks passed
@emosbaugh emosbaugh deleted the emosbaugh/sc-115680/test-public-address-flag branch November 10, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laverya laverya laverya approved these changes

Assignees
No one assigned
Labels
type::chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emosbaugh @laverya