Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DFBUGS-1326: [release-4.17] odf-info: stop owning the odf-info configMap #2968

Open
wants to merge 1 commit into
base: release-4.17
Choose a base branch
from

Conversation

rewantsoni
Copy link
Member

Since odf-info is created in operator namespace, in case of multi storageCluster, we get a "cross-namespace owner references are disallowed" issue. To address this, stop owning the configMap and watch the configMap from storageCluster reconciler

Signed-off-by: Rewant Soni [email protected]
(cherry picked from commit ccbefaa)

Manual backport for #2959

Since odf-info is created in operator namespace, in case of multi
storageCluster, we get a "cross-namespace owner references are
disallowed" issue. To address this, stop owning the configMap
and watch the configMap from storageCluster reconciler

Signed-off-by: Rewant Soni <[email protected]>
(cherry picked from commit ccbefaa)
Copy link
Contributor

openshift-ci bot commented Jan 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rewantsoni
Once this PR has been reviewed and has the lgtm label, please assign umangachapagain for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rewantsoni
Copy link
Member Author

rewantsoni commented Jan 15, 2025

/retitle DFBUGS-1326: [release-4.17] odf-info: stop owning the odf-info configMap

@openshift-ci openshift-ci bot changed the title odf-info: stop owning the odf-info configMap DFBUGS-1326: [release-4.17] odf-info: stop owning the odf-info configMap Jan 15, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid jira ticket of any type jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Jan 15, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 15, 2025

@rewantsoni: This pull request references [Jira Issue DFBUGS-1326](https://issues.redhat.com//browse/DFBUGS-1326), which is invalid:

  • expected the bug to target the "odf-4.17.3" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Since odf-info is created in operator namespace, in case of multi storageCluster, we get a "cross-namespace owner references are disallowed" issue. To address this, stop owning the configMap and watch the configMap from storageCluster reconciler

Signed-off-by: Rewant Soni [email protected]
(cherry picked from commit ccbefaa)

Manual backport for #2959

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rewantsoni
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting and removed jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Jan 15, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 15, 2025

@rewantsoni: This pull request references [Jira Issue DFBUGS-1326](https://issues.redhat.com//browse/DFBUGS-1326), which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.17.3) matches configured target version for branch (odf-4.17.3)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@iamniting
Copy link
Member

/test ocs-operator-bundle-e2e-aws

Copy link
Member

@iamniting iamniting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the vendor folder inside metrics? @malayparida2000 Dont we have a verifications for this?

@rewantsoni
Copy link
Member Author

rewantsoni commented Jan 15, 2025

@iamniting I am not sure if we need to update those

[rewantsoni ocs-operator[odf-info-4.17]] make verify-generated && make verify-deps 
Using existing [email protected] at /Users/rewantsoni/work/odf/ocs-operator/bin/controller-gen
Updating generated code
/Users/rewantsoni/work/odf/ocs-operator/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
Updating generated manifests
/Users/rewantsoni/work/odf/ocs-operator/bin/controller-gen rbac:roleName=manager-role crd:generateEmbeddedObjectMeta=true,allowDangerousTypes=true paths=./api/... webhook paths="./..." output:crd:artifacts:config=config/crd/bases
Verifying generated code and manifests
hack/verify-generated.sh
Success: no out of source tree changes found for generated files
Running deps-update
go mod tidy && go mod vendor
Running deps-update on api submodule
cd api && go mod tidy && go mod vendor
Running deps-update on metrics submodule
cd metrics && go mod tidy && go mod vendor
Verifying dependency files
hack/verify-dependencies.sh
Success: no out of source tree changes found for dependency files

@iamniting
Copy link
Member

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting and removed jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting labels Jan 15, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 15, 2025

@iamniting: This pull request references [Jira Issue DFBUGS-1326](https://issues.redhat.com//browse/DFBUGS-1326), which is invalid:

  • expected the bug to target the "odf-4.17.3" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@malayparida2000
Copy link
Contributor

malayparida2000 commented Jan 15, 2025

Can you update the vendor folder inside metrics? @malayparida2000 Dont we have a verifications for this?

That should be caught if there is something to update.

@malayparida2000
Copy link
Contributor

/test ocs-operator-bundle-e2e-aws

1 similar comment
@iamniting
Copy link
Member

/test ocs-operator-bundle-e2e-aws

@malayparida2000
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting label Feb 26, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 26, 2025

@malayparida2000: This pull request references [Jira Issue DFBUGS-1326](https://issues.redhat.com//browse/DFBUGS-1326), which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.17.6) matches configured target version for branch (odf-4.17.6)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting jira/valid-reference Indicates that this PR references a valid jira ticket of any type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants