-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DFBUGS-1326: [release-4.17] odf-info: stop owning the odf-info configMap #2968
base: release-4.17
Are you sure you want to change the base?
Conversation
Since odf-info is created in operator namespace, in case of multi storageCluster, we get a "cross-namespace owner references are disallowed" issue. To address this, stop owning the configMap and watch the configMap from storageCluster reconciler Signed-off-by: Rewant Soni <[email protected]> (cherry picked from commit ccbefaa)
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rewantsoni The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retitle DFBUGS-1326: [release-4.17] odf-info: stop owning the odf-info configMap |
@rewantsoni: This pull request references [Jira Issue DFBUGS-1326](https://issues.redhat.com//browse/DFBUGS-1326), which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@rewantsoni: This pull request references [Jira Issue DFBUGS-1326](https://issues.redhat.com//browse/DFBUGS-1326), which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/test ocs-operator-bundle-e2e-aws |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the vendor folder inside metrics? @malayparida2000 Dont we have a verifications for this?
@iamniting I am not sure if we need to update those
|
/jira refresh |
@iamniting: This pull request references [Jira Issue DFBUGS-1326](https://issues.redhat.com//browse/DFBUGS-1326), which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
That should be caught if there is something to update. |
/test ocs-operator-bundle-e2e-aws |
1 similar comment
/test ocs-operator-bundle-e2e-aws |
/jira refresh |
@malayparida2000: This pull request references [Jira Issue DFBUGS-1326](https://issues.redhat.com//browse/DFBUGS-1326), which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Since odf-info is created in operator namespace, in case of multi storageCluster, we get a "cross-namespace owner references are disallowed" issue. To address this, stop owning the configMap and watch the configMap from storageCluster reconciler
Signed-off-by: Rewant Soni [email protected]
(cherry picked from commit ccbefaa)
Manual backport for #2959