-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GPU Info #90
GPU Info #90
Conversation
…g me from creating a matching environment
minor adjustments to the requirements file (added nvidia-ml-py3) and the test_watermark file (added the local package through a relative path, may not be standard practice)
not sure how to deal with amd gpus but this method should highlight the number and the name of each gpu on the working machine. if there are no gpu devices available, it will print a message about nvidia drivers not being present
Awesome! This is a very exciting PR! Thanks! |
I just tried it on a machine with NVIDIA GPUs, and it couldn't find these. How did it look on your machine, am I missing any requirements @907Resident ? |
in reference to @rasbt's comments (see link below), I noticed that the nvidia-ml-py3 should actually be replaced with py3nvml. not sure how I misse that earlier. anyways, a follow comment in PR#90 will be added reflecting this commit
… interacting with gpu py3nvml
Hi @rasbt, I think I accidentally provided the incorrect pythonic interface for the gpu. As I mentioned in commit 87e7201, the correct package is I have made the correction, and the change can be seen in this Colab notebook (assuming the user has Colab Pro with GPU). The output can be viewed below. |
I also noticed that as of commit ab5cf05, that the automated checks have failed. But my local execution of But for some reason that I do no understand, the automated CI process is unable to install Nonetheless, I think once |
Thanks for the update! I did some fixes in the formatting and the CI works now! I'll also try it on a non-Colab GPU machine to make sure. |
I changed it to always use the indentation now. In hindsight, I think this should look better since it avoids the double-colon. I.e., it's now
or
|
Thanks for the updates and integrating my changes.
Yes, I agree. I only have access to a machine with one GPU; so, I did not think about formatting for multiple GPUs. But your formatting looks much better. @rasbt, at this point what do we need to do to merge this PR? Anything else you need me to add? |
@907Resident It looks all good to me know! Just added a changelog entry and am happy to merge (and make version release then)! Thanks so much for the PR. It's a super nice contribution! |
Cool, sounds good! |
TL;DR
Overall, I wanted an argument in
watermark
to allow the user to view GPU information.Details
gpu
towatermark
tests/
calledtest_gpu_info.py
, which should allow the maintainers of this repo to quickly run apytest
to ensure that thegpu
argument works as the maintainers see fit