importlib-related improvements #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @jamesmyatt! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-11-20 12:21:14 UTC |
jamesmyatt
changed the title
As recommended in docs: https://docs.python.org/3/library/importlib.html#importlib.__import__
As recommended in option 5: https://packaging.python.org/guides/single-sourcing-package-version/ Closes #56
jamesmyatt
changed the title
|
That looks great! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
importlib.import_modulerather than__import__: https://docs.python.org/3/library/importlib.html#importlib.__import__importlib.metadatarather thanpkg_resources: see option 5 in: https://packaging.python.org/guides/single-sourcing-package-version/This is inline with best-practice from the Python docs.
Closes #56