Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fleet: Git Repo: User can add a repo without a repository URL #12387

Closed
yonasberhe23 opened this issue Oct 28, 2024 · 1 comment
Closed

Fleet: Git Repo: User can add a repo without a repository URL #12387

yonasberhe23 opened this issue Oct 28, 2024 · 1 comment
Labels
area/fleet kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Milestone
v2.12.0

Comments

@yonasberhe23
Copy link
Contributor

Setup

  • Rancher version: 2.10, 2.9
  • Rancher UI Extensions:
  • Browser type & version: FF, Chrome

Describe the bug
After a user adds a repo without a repository URL, errors are thrown in the console and the repo list does not render. To avoid this maybe we should make the repository URL field required.

TypeError: e is undefined

To Reproduce

  1. go to Fleet > Git Repos
  2. click Add Repository
  3. input name
  4. click Next button
  5. click Create button
  6. refresh Git Repo page

Result
User can add a repo without a repository URL.

Expected Result
User is unable to add a repo without a repository URL

Screenshots

Screen.Recording.2024-10-28.at.2.06.06.PM.mov

Additional context
@yonasberhe23 yonasberhe23 added this to the v2.11.0 milestone Oct 28, 2024
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Oct 28, 2024
@torchiaf
Copy link
Member

Fixed by #13282

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/fleet kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Projects
None yet
Milestone
v2.12.0
Development

No branches or pull requests
3 participants
@nwmac @torchiaf @yonasberhe23