Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a Fleet GitRepo without non-mandatory repo breaks the GitRepo list #11924

Closed
richard-cox opened this issue Sep 16, 2024 · 1 comment
Closed
Labels
area/fleet kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Milestone

Comments

@richard-cox
Copy link
Member

richard-cox commented Sep 16, 2024

Setup

  • Rancher version: 2.9.1

Describe the bug

  • Users can create a git repo without supplying a spec.repo value
    • There's no block on the backend
    • There's no mandatory field notification in the UI
  • When then viewing the git repo list the UI fails to render

To Reproduce

  • Continuous Delivery --> Git Repos --> Create --> enter a name --> Next
  • On the git repo list refresh the page

Result
image

Expected Result

  • List shows with the two repos

Screenshots
image

Additional context

  • Additionally we need to consider marking the repo as mandatory (is this true?). If so we should be careful when enforcing to not break other modes
@richard-cox richard-cox added this to the v2.11.0 milestone Sep 16, 2024
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Sep 16, 2024
@torchiaf
Copy link
Member

I can't reproduce the issue in 2.11, the UI now supports empty repo + repository field is mandatory when creating new GitRepos from UI.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/fleet kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Projects
None yet
Development

No branches or pull requests

3 participants