Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support cargo binstall for release artifacts #652

Closed
bb010g opened this issue Oct 16, 2023 · 2 comments · Fixed by #653
Closed

[Feature Request] Support cargo binstall for release artifacts #652

bb010g opened this issue Oct 16, 2023 · 2 comments · Fixed by #653
Assignees
Labels
enhancement New feature or request

Comments

@bb010g
Copy link

bb010g commented Oct 16, 2023

pacaptr currently publishes pre-built artifacts with each release, but cargo binstall isn't aware of these artifacts, making cargo binstall pacaptr fail. See https://github.com/cargo-bins/cargo-binstall/blob/main/SUPPORT.md.

You can implement support via [package.metadata.binstall] keys in the crate manifest or via changing the artifact file name scheme to something cargo binstall will auto-detect. To see everything currently tried, try cargo binstall --log-level debug pacaptr. Specifying artifacts in the crate manifest should be preferred, as auto-detection requires querying the GitHub API about each tested artifact filename.

@rami3l rami3l self-assigned this Oct 17, 2023
@rami3l
Copy link
Owner

rami3l commented Oct 17, 2023

@bb010g Thanks for filing this issue! I'll definitely have a closer look when I'm available.

@rami3l
Copy link
Owner

rami3l commented Oct 17, 2023

@bb010g The binary names are generated by GoReleaser (which uses the Golang naming convention instead of the Rust ones), and I'm reluctant to change that again.

Thanks to your pointers, I have made the required additions in Cargo.toml, but I'm not sure if this will work correctly.
Would you mind reviewing my changes in #653 and, if possible, test the new manifest with something like the following?

cargo binstall pacaptr --manifest-path ./Cargo.toml --dry-run --log-level=debug

Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants