Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.val appears to be printing strange #474

Closed
njtierney opened this issue Jun 1, 2022 · 1 comment
Closed

.val appears to be printing strange #474

njtierney opened this issue Jun 1, 2022 · 1 comment
Labels
bug an unexpected problem or unintended behavior

Comments

@njtierney
Copy link

When using .val I get some strange printing, which doesn't happen if I use another inline markup like .key.

Here's a reprex:

library(cli)
n_dist <- 4
dim <- c(5,1)
weights_dim <- c(2,5,1)
msg <- cli::format_error(
  c(
    "the dimension of weights must be either:",
    "{.val {n_dist}x1} or \\
    {.val {n_dist}x{paste(dim, collapse = 'x')}}",
    " but was {.val {paste(weights_dim, collapse = 'x')}}"
  )
)

stop(msg, call. = FALSE)
#> Error: the dimension of weights must be either:
#> "4x1" or "4x\"5x1\""
#> but was "2x5x1"

library(cli)
msg <- cli::format_error(
  c(
    "the dimension of weights must be either:",
    "{.key {n_dist}x1} or \\
    {.key {n_dist}x{paste(dim, collapse = 'x')}}",
    " but was {.key {paste(weights_dim, collapse = 'x')}}"
  )
)

stop(msg, call. = FALSE)
#> Error: the dimension of weights must be either:
#> [4x1] or [4x5x1]
#> but was [2x5x1]

Created on 2022-06-01 by the reprex package (v2.0.1)

Session info
sessioninfo::session_info()
#> ─ Session info ───────────────────────────────────────────────────────────────
#>  setting  value
#>  version  R version 4.2.0 (2022-04-22)
#>  os       macOS Big Sur/Monterey 10.16
#>  system   x86_64, darwin17.0
#>  ui       X11
#>  language (EN)
#>  collate  en_AU.UTF-8
#>  ctype    en_AU.UTF-8
#>  tz       Australia/Perth
#>  date     2022-06-01
#>  pandoc   2.17.1.1 @ /Applications/RStudio.app/Contents/MacOS/quarto/bin/ (via rmarkdown)
#> 
#> ─ Packages ───────────────────────────────────────────────────────────────────
#>  package     * version date (UTC) lib source
#>  cli         * 3.3.0   2022-04-25 [1] CRAN (R 4.2.0)
#>  digest        0.6.29  2021-12-01 [1] CRAN (R 4.2.0)
#>  evaluate      0.15    2022-02-18 [1] CRAN (R 4.2.0)
#>  fastmap       1.1.0   2021-01-25 [1] CRAN (R 4.2.0)
#>  fs            1.5.2   2021-12-08 [1] CRAN (R 4.2.0)
#>  glue          1.6.2   2022-02-24 [1] CRAN (R 4.2.0)
#>  highr         0.9     2021-04-16 [1] CRAN (R 4.2.0)
#>  htmltools     0.5.2   2021-08-25 [1] CRAN (R 4.2.0)
#>  knitr         1.39    2022-04-26 [1] CRAN (R 4.2.0)
#>  magrittr      2.0.3   2022-03-30 [1] CRAN (R 4.2.0)
#>  reprex        2.0.1   2021-08-05 [1] CRAN (R 4.2.0)
#>  rlang         1.0.2   2022-03-04 [1] CRAN (R 4.2.0)
#>  rmarkdown     2.14    2022-04-25 [1] CRAN (R 4.2.0)
#>  rstudioapi    0.13    2020-11-12 [1] CRAN (R 4.2.0)
#>  sessioninfo   1.2.2   2021-12-06 [1] CRAN (R 4.2.0)
#>  stringi       1.7.6   2021-11-29 [1] CRAN (R 4.2.0)
#>  stringr       1.4.0   2019-02-10 [1] CRAN (R 4.2.0)
#>  withr         2.5.0   2022-03-03 [1] CRAN (R 4.2.0)
#>  xfun          0.31    2022-05-10 [1] CRAN (R 4.2.0)
#>  yaml          2.3.5   2022-02-21 [1] CRAN (R 4.2.0)
#> 
#>  [1] /Library/Frameworks/R.framework/Versions/4.2/Resources/library
#> 
#> ──────────────────────────────────────────────────────────────────────────────

Also worth noting when I do this in Rstudio, I get:

> stop(msg, call. = FALSE)
Error: the dimension of weights must be either:
"\033[34m4\033[39mx1" or "\033[34m4\033[39mx\033[34m\"5x1\"\033[39m"
but was "2x5x1"

image

@gaborcsardi gaborcsardi added the bug an unexpected problem or unintended behavior label Jun 1, 2022
@gaborcsardi
Copy link
Member

Simpler reprex:

cli::cli_text("pre {.val x {'foo'} y} post")
pre "x \033[34mfoo\033[39m y" post

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

2 participants