#75: Added post limits.

Author: SoftlySplinter

tentd/blueprints/posts.py

@@ -5,6 +5,8 @@
 from flask import json, request, g, abort, make_response
 from flask.views import MethodView
 
+from mongoengine import Q
+
 from tentd.lib.flask import EntityBlueprint, jsonify
 from tentd.utils import follow
 from tentd.utils.exceptions import APIBadRequest
@@ -13,6 +15,7 @@
 
 posts = EntityBlueprint('posts', __name__, url_prefix='/posts')
 
+DEFAULT_POST_LIMIT = 200
 
 @posts.route_class('', endpoint='posts')
 class PostsView(MethodView):
@@ -22,7 +25,12 @@ class PostsView(MethodView):
 
     def get(self):
         """Gets all posts"""
-        return jsonify(g.entity.posts)
+        query = []
+        limit = DEFAULT_POST_LIMIT
+        if 'limit' in request.args:
+            limit = min(int(request.args['limit']), limit)
+
+        return jsonify(g.entity.posts(*query).limit(limit))
 
     def post(self):
         """ Used by apps to create a new post.

tentd/tests/blueprints/test_posts.py

@@ -60,13 +60,22 @@ def test_get_post_mentions(post):
 
 def test_get_posts(entity, post):
     """Test that getting all posts returns correctly."""
-    response = GET('posts.posts', secure=True)
+    response = SGET('posts.posts')
     posts = jsonify([p.to_json() for p in entity.posts])
     assert response.data == posts.data
 
 def test_get_empty_posts(entity):
     """Test that /posts works when there are no posts to return"""
     assert SGET('posts.posts').json() == list()
+
+def test_get_filtered_posts(entity, posts):
+    """Test that /posts?limit=1 works"""
+    # Check limits from 0 to N+1 (check boundary conditions)
+    for i in xrange(len(posts) + 1):
+        # Make sure the length of posts returned is either i or the number of
+        # posts which exist.
+        assert len(SGET('posts.posts', limit=i).json()) == min(i, len(posts))
+
 
 def test_update_post(post):
     """Test a single post can be updated."""

tentd/tests/conftest.py

@@ -117,6 +117,19 @@ def post(request, entity):
     request.addfinalizer(post.delete)
     return post
 
+@fixture
+def posts(request, entity):
+    """Sets up multiple posts"""
+    schema = 'https://tent.io/types/post/status/v0.1.0'
+    posts = []
+    for i in xrange(15):
+        post = Post.new(entity=entity, schema=schema, content={
+            'text': 'Post {}'.format(i)})
+        post.save()
+        request.addfinalizer(post.delete)
+        posts.append(post)
+    return posts
+
 @fixture
 def follower(request, entity):
     """A follower with an identity of http://follower.example.com"""