Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contribution guidelines for testing of plots #53

Closed
mberz opened this issue Apr 5, 2024 · 3 comments
Closed

Add contribution guidelines for testing of plots #53

mberz opened this issue Apr 5, 2024 · 3 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@mberz
Copy link
Member

mberz commented Apr 5, 2024

We're currently lacking guidelines on the testing of plots using pre-generated baseline graphics.
There's limited documentation as part of the testing files in pyfar, which should be moved to the docs (best case the joint contribution guidelines on the gallery docs in, see #51)

@mberz mberz added the documentation Improvements or additions to documentation label Apr 5, 2024
@mberz
Copy link
Member Author

mberz commented Feb 21, 2025

Related pyfar/spharpy#96

@mberz mberz moved this from Backlog to Open Discussion in Weekly Planning Feb 21, 2025
@f-brinkmann
Copy link
Member

We found that using best practice for testing differences between baseline and newly generated plots as recommended by Matplotlib does not work. Even if using the same backend, plots differ by a few pixels between operating systems and automatic testing of differences does not work.

We will use pyfar as our best practive and document that in the guidelines. @f-brinkmann will do a draft.

@f-brinkmann f-brinkmann self-assigned this Feb 21, 2025
@f-brinkmann f-brinkmann moved this from Open Discussion to Implementation in progress in Weekly Planning Feb 21, 2025
@ahms5
Copy link
Member

ahms5 commented Mar 28, 2025

done by #92

@ahms5 ahms5 closed this as completed Mar 28, 2025
@github-project-automation github-project-automation bot moved this from Implementation in progress to Done in Weekly Planning Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

No branches or pull requests

3 participants