Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Setup helpers: don't set minimum macOS higher than current macOS #2620

Closed
henryiii opened this issue Oct 26, 2020 · 0 comments · Fixed by #2622
Closed

[BUG] Setup helpers: don't set minimum macOS higher than current macOS #2620

henryiii opened this issue Oct 26, 2020 · 0 comments · Fixed by #2622

Comments

@henryiii
Copy link
Collaborator

Issue description

Currently the minimum macOS version is set to 10.14, even if you run on 10.13 or 10.12. While users should set the correct environment variable instead, the default should be smarter and not set a number lower than the current macOS version.

Also see pybind/python_example#44

Reproducible example code

Seen in pybind/python_example#64.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: min macos henryiii/pybind11
1 participant
@henryiii